Conversation
Add @zw0610 as the owner. - https://github.com/kubeflow/training-operator/commits?author=zw0610 - https://github.com/kubeflow/common/commits?author=zw0610 Lucas helped to improve the kubeflow common and migrated mpi and pytorch to the training operator. I suggest adding him as an approver in training operator.
google-oss-prow
bot
requested review from
ChanYiLin,
jinchihe and
terrytangyuan
|
/cc @kubeflow/wg-training-leads /cc @zw0610 |
|
@gaocegege: GitHub didn't allow me to request PR reviews from the following users: /cc. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 1506458901
💛 - Coveralls |
There was a problem hiding this comment.
LGTM. Thanks @zw0610 for your contributions! Let’s wait a bit for feedback from others since it’s Thanksgiving break.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
andreyvelich
left a comment
andreyvelich
left a comment
There was a problem hiding this comment.
Thank you for your great work and help @zw0610!
/lgtm
|
/cc @Jeffwan |
|
Thanks @zw0610 |
|
/lgtm @zw0610 devotes lots of his energy to this project. Great to have him here. |
|
/hold cancel |
|
@zw0610 Congrats and welcome! |
|
Thanks everyone! |
7 participants
Add @zw0610 as the approver.
Lucas helped to improve the kubeflow common and migrated mpi and pytorch to the training operator. I suggest adding him as an approver in training operator.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: