Set a Running condition when the XGBoostJob is completed and doesn't have a Running condition#1789
Set a Running condition when the XGBoostJob is completed and doesn't have a Running condition#1789google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom tenzen-y:fix-xgboost-bug
Conversation
Pull Request Test Coverage Report for Build 4546766224
💛 - Coveralls |
…have a Running condition Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
|
@terrytangyuan I addressed your comment. PTAL. |
|
/lgtm |
|
/assign @johnugeorge @nagar-ajay |
|
@tenzen-y: GitHub didn't allow me to assign the following users: nagar-ajay. Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Somehow, I missed this PR Sorry for the delay @tenzen-y /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I fixed the reconciling error in XGBoost Job.
When XGBoostJob is completed (succeeded or failed) before the controller sets a
Runningcondition, XGBoostJob finishes without aRunningcondition.So, I modified the controller so that the controller can set a
Runningcondition when the XGboostJob is completed and doesn't have aRunningcondition.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Part-of #1779
Checklist: