Removing reconciler code

[johnugeorge]

The common reconciler code is dead piece of code which can be removed.

Ref: #1816

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [johnugeorge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tenzen-y]

Can we remove all files in the test_job?

[johnugeorge]

It is being used here
https://github.com/kubeflow/training-operator/blob/4dd0d0909210edc7e1a31a5987cb32dc834d682b/pkg/controller.v1/common/job_test.go#L27

and
https://github.com/kubeflow/training-operator/blob/4dd0d0909210edc7e1a31a5987cb32dc834d682b/pkg/controller.v1/common/pod_test.go#L22

[tenzen-y]

Oh, I see. We should replace those tests with a concrete framework such as TFJob and then remove all test_job codes. However, we can work on the improvement at follow-ups.

[johnugeorge]

Yes. We can cleanup that separately. Also, I see that many tests are using test job utils.

https://github.com/kubeflow/training-operator/blob/4dd0d0909210edc7e1a31a5987cb32dc834d682b/pkg/controller.v1/control/pod_control_test.go#L33

[tenzen-y]

I added a task: #1816 (comment)

[coveralls]

Pull Request Test Coverage Report for Build 5749372991

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+2.5%) to 42.869%

---

Totals
Change from base Build 5733624152:	2.5%
Covered Lines:	3745
Relevant Lines:	8736

---

💛 - Coveralls

[tenzen-y]

/lgtm