Creating service account where approriate for MPI Job#1917
Merged
google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom Sep 20, 2023
Merged
Creating service account where approriate for MPI Job#1917google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom
google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom
Conversation
Pull Request Test Coverage Report for Build 6244561289
💛 - Coveralls |
Member
andreyvelich
left a comment
andreyvelich
left a comment
There was a problem hiding this comment.
Thank you for updating this @rpemsel!
As we discussed, if service account already exists, controller won't create it.
/assign @tenzen-y @alculquicondor @terrytangyuan
Please take a look.
|
/lgtm |
Member
|
/approve |
1 similar comment
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, rpemsel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: If a MPI job is supposed to run with a certain K8s service account, then this service account can now be used.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #1897
Checklist: