Skip to content

chore: pkg import only once#1950

Merged
google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom
testwill:pkg-import
Nov 23, 2023
Merged

chore: pkg import only once#1950
google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom
testwill:pkg-import

Conversation

@testwill
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@johnugeorge
Copy link
Member

Thanks for this fix.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, testwill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6966600551

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 42.803%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/common/job.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 6 80.67%
Totals Coverage Status
Change from base Build 6941773842: -0.06%
Covered Lines: 3747
Relevant Lines: 8754

💛 - Coveralls

@google-oss-prow google-oss-prow bot merged commit b199882 into kubeflow:master Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants