E2E: Replace outdated images with latest ones#2083
Merged
google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom Apr 25, 2024
tenzen-y:replace-outdated-pytorch-images-in-ci
Merged
E2E: Replace outdated images with latest ones#2083google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom tenzen-y:replace-outdated-pytorch-images-in-ci
google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom
tenzen-y:replace-outdated-pytorch-images-in-ci
Conversation
Pull Request Test Coverage Report for Build 8839078431Details
💛 - Coveralls |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Member
Author
|
Everything looks good. |
andreyvelich
approved these changes
Apr 25, 2024
Member
andreyvelich
left a comment
There was a problem hiding this comment.
Thank you for fixing this @tenzen-y!
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ckyuto
pushed a commit
to ckyuto/training-operator
that referenced
this pull request
Apr 26, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Weiyu Yen <ckyuto@gmail.com>
ckyuto
pushed a commit
to ckyuto/training-operator
that referenced
this pull request
Apr 26, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Weiyu Yen <ckyuto@gmail.com>
johnugeorge
pushed a commit
to johnugeorge/training-operator
that referenced
this pull request
Apr 28, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
johnugeorge
pushed a commit
to johnugeorge/training-operator
that referenced
this pull request
Apr 28, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the current PyTorch (
gcr.io/kubeflow-ci/pytorch-dist-mnist-test:v1.0) and Horovod (horovod/horovod:0.20.0-tf2.3.0-torch1.6.0-mxnet1.5.0-py3.7-cpu) images, it seems that we can not download the model because both images are too older. So, I replaced those images with thehorovod/horovod:0.28.1and thekubeflow/pytorch-dist-mnist:latest.Also, I added the action to free up disks on the integration tests to avoid errors the below due to the huge image size.
Furthermore, I increased the required resources to speed up integration tests based on this article.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: