Skip to content

verify-boilerplate.sh: fix path to script #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2021
Merged

verify-boilerplate.sh: fix path to script #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
verify-boilerplate.sh: fix path to script 
The previous path was wrong because it was relative to the directory
being checked, not the release-tools directory:

csi-driver-host-path$ ./release-tools/verify-boilerplate.sh
Verifying boilerplate
./release-tools/verify-boilerplate.sh: line 37: /nvme/gopath/src/github.com/kubernetes-csi/csi-driver-host-path/boilerplate/boilerplate.py: No such file or directory
Done
  • Loading branch information
@pohly
pohly committed Jan 17, 2021
commit dbd896722b910fe2f041b4d9a76b2ab31b407e8d
3 changes: 1 addition & 2 deletions verify-boilerplate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ TOOLS="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
# Directory to check. Default is the parent of the tools themselves.
ROOT="${1:-${TOOLS}/..}"

boilerDir="${ROOT}/boilerplate"
boiler="${boilerDir}/boilerplate.py"
boiler="${TOOLS}/boilerplate/boilerplate.py"
Copy link
Collaborator

@msau42 msau42 Jan 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also fix the script to check the return code?

Copy link
Contributor Author

@pohly pohly Jan 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better, yes. I don't have a solution readily available, though.


mapfile -t files_need_boilerplate < <("${boiler}" --rootdir="${ROOT}" --verbose)

Expand Down