Enable the VolumeGroupSnapshot tests #283

Phaow · 2025-09-30T09:39:44Z

What type of PR is this?
/kind test

What this PR does / why we need it:

Enable the VolumeGroupSnapshot tests.
Used the temporary job for vgs pull-kubernetes-e2e-storage-kind-vgs verified it works as expected in live PR.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Penghao <[email protected]>

Phaow · 2025-09-30T11:06:16Z

/test pull-kubernetes-csi-release-tools-csi-test

Phaow · 2025-09-30T11:23:26Z

Hi @xing-yang @jsafrane @gnufied @msau42 , could you please help review when you get a chance? Thank you!

Phaow · 2025-09-30T11:24:10Z

/assign @xing-yang @jsafrane @gnufied @msau42

prow.sh

k8s-ci-robot · 2025-10-01T14:23:22Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Phaow
Once this PR has been reviewed and has the lgtm label, please ask for approval from jsafrane. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Phaow · 2025-10-01T14:24:54Z

/label tide/merge-method-squash

Phaow · 2025-10-10T08:41:28Z

Hi @jsafrane , could you help take a look again when you get a chance? Thank you! I hack some codes in master...Phaow:csi-release-tools:dev and verify it works, which needs update in job definition part, the script also needs the https://github.com/kubernetes-csi/csi-release-tools/blob/master/filter-junit.go, I will download it in prow job definition part.

Signed-off-by: Penghao <[email protected]>

Phaow · 2025-10-13T02:11:56Z

/test pull-kubernetes-csi-release-tools-external-provisioner

Phaow · 2025-10-13T05:49:43Z

/test pull-kubernetes-csi-release-tools-external-provisioner

prow.sh

jsafrane · 2025-10-13T11:15:45Z

prow.sh

+        vgs)
+            # VGS tests are in in-tree/core tests; do NOT pass -storage.testdriver
+            ginkgo_target="${CSI_PROW_WORK}/e2e.test"
+            cd "${e2e_src_dir}" || die "cd ${e2e_src_dir} failed"
+            ;;


I admit I don't understand why there is vgs as a special value. IMHO the VGS tests don't change how junit fiels a re generated / moved or what binaries to run.

Please correct me if I am wrong. There were two kinds of tests:

local, running "e2e-local.test", if available

non-local, running "e2e.test -storage.testdriver=test-driver.yaml" with csi-driver-hostpath with CSI sidecars either compiled from a PR or canary or whatever.

Now you want to add a new set of tests

e2e.test with in-tree tests, that have all sidecars hardcoded in Kubernetes manifests, only with optional "--feature-gate=CSIVolumeGroupSnapshot=true" in its external-snapshotter (see Refine: VolumeGroupSnapshot tests kubernetes/kubernetes#134214). Should we call it in-tree? And focus not just Feature:volumegroupsnapshot, but all [Driver: csi-hostpath]

Now that I am reading what I wrote, should the in-tree tests use all sidecars from the PR they run in? Or even canary? That would be definitely for a future improvement, not this PR.

non-local, running "e2e.test -storage.testdriver=test-driver.yaml" with csi-driver-hostpath with CSI sidecars either compiled from a PR or canary or whatever.

It seems currently only snapshot controller image could used the one compile from the PR, the snapshotter and other sidecar images do not override for hostpath csi driver->https://github.com/kubernetes-csi/csi-release-tools/blob/master/prow.sh#L720-L769 .

should the in-tree tests use all sidecars from the PR they run in?

From my understanding, we'd better keep this part in the prow.sh with external CSI testsuite, which we could replace the hostpath sidecar images directly.

To run vgs test toward external hostpath csi driver we still needs hack 90b69e4#diff-c2d96beb8cf73c62f7ae059aff96e381a8d73317df3ce356f36ba6b46338959dR784-R804 and kubernetes/kubernetes#134633.
So maybe we'd better choose to use the external hostpath csi driver for sidecars tests, right?

should the in-tree tests use all sidecars from the PR they run in?

From my understanding, we'd better keep this part in the prow.sh with external CSI testsuite, which we could replace the hostpath sidecar images directly.

Yes, that's what I think too. But this PR adds vgs tests that will test with csi-driver-hospath yaml files hardcoded in k/k. It would be better to run them with the hostpath driver installed in prow.sh.

Change to run vgs tests from csi external and integration with k/k PR works as expected.

Signed-off-by: Penghao <[email protected]>

gnufied · 2025-10-23T14:14:24Z

@Phaow Sorry if you answered this already, but why aren't we implementing this via - https://github.com/kubernetes-csi/external-snapshotter/blob/master/.prow.sh ? Is that not doable?

Phaow · 2025-10-23T14:40:08Z

Hi @gnufied , thanks for looking into this, we have a discussion try to use it also for k/k vgs testing ->
https://kubernetes.slack.com/archives/C8EJ01Z46/p1758723200461749

Signed-off-by: Penghao <[email protected]>

prow.sh

Signed-off-by: Penghao <[email protected]>

prow.sh

gnufied · 2025-10-27T19:28:17Z

prow.sh

+#
+# This can be used as an example post-install hook by setting:
+#   export CSI_PROW_DRIVER_POSTINSTALL="vgs_post_install"
+vgs_post_install () {


Where is this being called from? Did you mean to keep this as an example and then have it actually in external-snapshotter repo or did you mean to call this function inline?

I expect call this inline for k/k storage kind jobs just declare the env CSI_PROW_DRIVER_POSTINSTALL="vgs_post_install" in https://github.com/kubernetes/test-infra/pull/35680/files#diff-5ca5c1a86ebcf3b5a8105d06bf3010fe3b0f8d4b3093cf4668d84389e3bea3e3R340 . Actually in external-snapshotter repo we could reuse the inline function, in k/k we do not add the release tool subtree, if we want to reuse it we have to make it inline(k/k could not reuse the post_install from external sidecar repos directly unless we also clone/copy it from sidecar). Not sure I missed something, any better ideas are welcome ^^

Not sure I missed something, any better ideas are welcome ^^

I meant if you intend to use this function, then it should be assigned to CSI_PROW_DRIVER_POSTINSTALL variable or if you intend this to be used from external-snapshotter repo, then this function should be moved to .prow.sh of that repository.

With respect to vgs I intend to use this function, yeah it should be assigned to CSI_PROW_DRIVER_POSTINSTALL variable in job configuration. It could be used for both external-snapshotter and k/k vgs jobs.

Signed-off-by: Penghao <[email protected]>

Phaow · 2025-11-04T14:12:49Z

Hi @gnufied , could you help take a look again when you get a chance? Thank you! ^^

gnufied · 2025-11-04T21:15:07Z

/lgtm

Phaow · 2025-11-05T10:45:39Z

Hi @jsafrane , could you help take a review again when you get a chance? Thank you! ^^

k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 30, 2025

k8s-ci-robot requested review from humblec and jingxu97 September 30, 2025 09:39

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2025

Enable the VolumeGroupSnapshot tests

9fb036e

Signed-off-by: Penghao <[email protected]>

Phaow force-pushed the enable-vgs-tests branch from d0ea3ee to 9fb036e Compare September 30, 2025 10:08

k8s-ci-robot assigned gnufied, jsafrane, msau42 and xing-yang Sep 30, 2025

Phaow mentioned this pull request Sep 30, 2025

WIP: Enable the VolumeGroupSnapshot tests kubernetes-csi/external-snapshotter#1331

Draft

jsafrane reviewed Sep 30, 2025

View reviewed changes

prow.sh Outdated Show resolved Hide resolved

prow.sh Outdated Show resolved Hide resolved

prow.sh Outdated Show resolved Hide resolved

prow.sh Outdated Show resolved Hide resolved

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 1, 2025

Phaow force-pushed the enable-vgs-tests branch from a1ecfa1 to 5005ced Compare October 10, 2025 06:50

Phaow requested a review from jsafrane October 10, 2025 08:20

Phaow mentioned this pull request Oct 11, 2025

Refine vgs jobs kubernetes/test-infra#35680

Open

Fix: refine functions

9160d31

Signed-off-by: Penghao <[email protected]>

Phaow force-pushed the enable-vgs-tests branch from 5005ced to 9160d31 Compare October 11, 2025 11:15

jsafrane reviewed Oct 13, 2025

View reviewed changes

Phaow added 2 commits October 16, 2025 16:17

Fix: remove duplicated diff and apply

8ab66fa

Signed-off-by: Penghao <[email protected]>

Fix: run vgs tests from csi external

494f879

Signed-off-by: Penghao <[email protected]>

Fix: shellcheck

fa3507d

Signed-off-by: Penghao <[email protected]>

Phaow requested a review from jsafrane October 23, 2025 15:49

gnufied reviewed Oct 23, 2025

View reviewed changes

prow.sh Show resolved Hide resolved

gnufied reviewed Oct 23, 2025

View reviewed changes

prow.sh Outdated Show resolved Hide resolved

feat: introduce CSI_PROW_DRIVER_POSTINSTALL hook mechanism

3467e7a

Signed-off-by: Penghao <[email protected]>

gnufied reviewed Oct 24, 2025

View reviewed changes

prow.sh Outdated Show resolved Hide resolved

Phaow requested a review from gnufied October 27, 2025 01:49

gnufied reviewed Oct 27, 2025

View reviewed changes

gnufied mentioned this pull request Oct 27, 2025

{WIP} Enable VAC tests via postinstall hooks kubernetes-csi/external-resizer#541

Open

Phaow requested a review from gnufied October 28, 2025 02:12

fix: use single hook for driver post install

0ba0d8e

Signed-off-by: Penghao <[email protected]>

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025

Enable the VolumeGroupSnapshot tests #283

Are you sure you want to change the base?

Enable the VolumeGroupSnapshot tests #283

Conversation

Phaow commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Phaow commented Sep 30, 2025

Uh oh!

Phaow commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Phaow commented Sep 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

k8s-ci-robot commented Oct 1, 2025

Uh oh!

Phaow commented Oct 1, 2025

Uh oh!

Phaow commented Oct 10, 2025

Uh oh!

Phaow commented Oct 13, 2025

Uh oh!

Phaow commented Oct 13, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gnufied commented Oct 23, 2025

Uh oh!

Phaow commented Oct 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Phaow commented Nov 4, 2025

Uh oh!

gnufied commented Nov 4, 2025

Uh oh!

Phaow commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Phaow commented Sep 30, 2025 •

edited

Loading

Phaow commented Sep 30, 2025 •

edited

Loading