Skip to content

Add comment about deletion #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add comment about deletion #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-1.1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
`--leader-election-type=leases` ([#261](https://github.com/kubernetes-csi/external-provisioner/pull/261))

## Other Notable Changes
* Handle deletion of volumes associated with in-tree plugins that are migrated to CSI ([#273](https://github.com/kubernetes-csi/external-provisioner/pull/273))
Copy link
Collaborator

@msau42 msau42 May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this in a new section

'''

Changes since 1.1.0

'''

Actually, can you cherry pick the fix to release-1.1 branch and then make the changelog PR in that branch?

Copy link
Contributor Author

@ddebroy ddebroy May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry pick PR opened at #276

Copy link
Contributor

@davidz627 davidz627 May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should still merge this into master right?

Copy link
Collaborator

@msau42 msau42 May 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the next 1.2.0, we'll probably have a new release notes generation tool that can populate this

Copy link
Contributor Author

@ddebroy ddebroy May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closing for now then.

* vendor: update to k8s.io 1.14, avoid glog ([#262](https://github.com/kubernetes-csi/external-provisioner/pull/262))
* Deprecate provisioner arguments ([#255](https://github.com/kubernetes-csi/external-provisioner/pull/255))
* Do not stop saving PVs to API server ([#251](https://github.com/kubernetes-csi/external-provisioner/pull/251))
Expand Down