Skip to content

Conversation

@leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Dec 3, 2019

Is this a bug fix or adding new feature?
Use main from e2e tester. So that we don't need to have a separate main.go in each individual projects for e2e testing.

Depends on: aws/aws-k8s-tester#65

/cc @M00nF1sh

@k8s-ci-robot k8s-ci-robot requested a review from M00nF1sh December 3, 2019 08:31
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 3, 2019
@leakingtapan
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019
@leakingtapan leakingtapan force-pushed the tester branch 3 times, most recently from 0ca18f7 to 0567cb1 Compare December 3, 2019 08:52
@leakingtapan leakingtapan merged commit 906fda6 into kubernetes-sigs:master Dec 4, 2019
@leakingtapan leakingtapan deleted the tester branch December 4, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants