Skip to content

prevent controller runtime complaining about SetupLogger() was never … #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024
Merged

prevent controller runtime complaining about SetupLogger() was never … #3724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
prevent controller runtime complaining about SetupLogger() was never … 
…called
  • Loading branch information
@oliviassss
oliviassss committed May 29, 2024
commit e6da49b5f773d2f5f79cf0dc249416bc00c477a4
3 changes: 3 additions & 0 deletions test/framework/utils/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package utils

import (
"fmt"
logf "sigs.k8s.io/controller-runtime/pkg/log"

httpexpectv2 "github.com/gavv/httpexpect/v2"
"github.com/go-logr/logr"
Expand Down Expand Up @@ -39,5 +40,7 @@ func NewGinkgoLogger() (logr.Logger, httpexpectv2.LoggerReporter) {
zap.Level(zapraw.InfoLevel),
zap.WriteTo(ginkgov2.GinkgoWriter),
zap.Encoder(encoder))
// this line is to prevent controller runtime complaining about SetupLogger() was never called
logf.SetLogger(logger)
return logger, &defaultGinkgoLogger{logger: logger}
}