Skip to content

Add prometheus metrics to internal controller #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 2, 2018
Merged

Add prometheus metrics to internal controller #132

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f9fe74f
Add metrics listener to manager
JoelSpeed Aug 29, 2018
04afe8c
Add global metrics registry
JoelSpeed Sep 17, 2018
6b8baee
Start http server for serving metrics
JoelSpeed Aug 29, 2018
ebb4188
Update dependencies
JoelSpeed Aug 29, 2018
136aa94
Add QueueLength Metric
JoelSpeed Sep 17, 2018
d18803a
Add reconcile errors counter
JoelSpeed Sep 3, 2018
40c688a
Add reconcile time histogram
JoelSpeed Sep 3, 2018
858ccd1
Make sure multiple controllers can be registered
JoelSpeed Sep 13, 2018
b147114
Don't send error for server shutdown
JoelSpeed Sep 17, 2018
b063917
Pin prometheus dependency in Gopkg.toml
JoelSpeed Oct 31, 2018
9bc6981
Fix tests after upgrade to prometheus v0.9.0
JoelSpeed Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't send error for server shutdown
  • Loading branch information
@JoelSpeed
JoelSpeed committed Oct 31, 2018
commit b147114dc5bd647d4d5912ce3c6e41c39aaf9412
2 changes: 1 addition & 1 deletion pkg/manager/internal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ func (cm *controllerManager) serveMetrics(stop <-chan struct{}) {
}
// Run the server
go func() {
if err := server.Serve(cm.metricsListener); err != nil {
if err := server.Serve(cm.metricsListener); err != nil && err != http.ErrServerClosed {
cm.errChan <- err
}
}()
Expand Down