-
Notifications
You must be signed in to change notification settings - Fork 1.2k
✨ EnvTest Binaries Setup Tool #1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 2 commits into
kubernetes-sigs:master
from
DirectXMan12:feature/envtest-setup-tool
Apr 30, 2021
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Envtest Binary Version Manager Tool
This introduces an envtest binary manager tool. It can download binaries from GCS, list available versions, print out help for switching between them, and remove old ones. By default, it downloads binaries into an OS-specific cache directory, as per the OS's conventions, but this can be overridden.
- Loading branch information
commit 235d62a9d93f0183035787518f26142000972b14
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| # Envtest Binaries Manager | ||
|
|
||
| This is a small tool that manages binaries for envtest. It can be used to | ||
| download new binaries, list currently installed and available ones, and | ||
| clean up versions. | ||
|
|
||
| To use it, just go-install it on 1.16+ (it's a separate, self-contained | ||
| module): | ||
|
|
||
| ```shell | ||
| go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest | ||
| ``` | ||
|
|
||
| For full documentation, run it with the `--help` flag, but here are some | ||
| examples: | ||
|
|
||
| ```shell | ||
| # download the latest envtest, and print out info about it | ||
| setup-envtest use | ||
|
|
||
| # download the latest 1.19 envtest, and print out the path | ||
| setup-envtest use -p path 1.19.x! | ||
|
|
||
| # switch to the most recent 1.21 envtest on disk | ||
| source <(setup-envtest use -i -p env 1.21.x) | ||
|
|
||
| # list all available local versions for darwin/amd64 | ||
| setup-envtest list -i --os darwin --arch amd64 | ||
|
|
||
| # remove all versions older than 1.16 from disk | ||
| setup-envtest cleanup <1.16 | ||
|
|
||
| # use the value from $KUBEBUILDER_ASSETS if set, otherwise follow the normal | ||
| # logic for 'use' | ||
| setup-envtest --use-env | ||
|
|
||
| # use the value from $KUBEBUILDER_ASSETS if set, otherwise use the latest | ||
| # installed version | ||
| setup-envtest use -i --use-env | ||
|
|
||
| # sideload a pre-downloaded tarball as Kubernetes 1.16.2 into our store | ||
| setup-envtest sideload 1.16.2 < downloaded-envtest.tar.gz | ||
| ``` | ||
|
|
||
| ## Where does it put all those binaries? | ||
|
|
||
| By default, binaries are stored in a subdirectory of an OS-specific data | ||
| directory, as per the OS's conventions. | ||
|
|
||
| On Linux, this is `$XDG_DATA_HOME`; on Windows, `%LocalAppData`; and on | ||
| OSX, `~/Library/Application Support`. | ||
|
|
||
| There's an overall folder that holds all files, and inside that is | ||
| a folder for each version/platform pair. The exact directory structure is | ||
| not guarnateed, except that the leaf directory will contain the names | ||
| expected by envtest. You should always use `setup-envtest fetch` or | ||
| `setup-envtest switch` (generally with the `-p path` or `-p env` flags) to | ||
| get the directory that you should use. | ||
|
|
||
| ## Why do I have to do that `source <(blah blah blah)` thing | ||
|
|
||
| This is a normal binary, not a shell script, so we can't set the parent | ||
| process's environment variables. If you use this by hand a lot and want | ||
| to save the typing, you could put something like the following in your | ||
| `~/.zshrc` (or similar for bash/fish/whatever, modified to those): | ||
|
|
||
| ```shell | ||
| setup-envtest() { | ||
| if (($@[(Ie)use])); then | ||
| source <($GOPATH/bin/setup-envtest "$@" -p env) | ||
| else | ||
| $GOPATH/bin/setup-envtest "$@" | ||
| fi | ||
| } | ||
| ``` | ||
|
|
||
| ## What if I don't want to talk to the internet? | ||
|
|
||
| There are a few options. | ||
|
|
||
| First, you'll probably want to set the `-i/--installed` flag. If you want | ||
| to avoid forgetting to set this flag, set the `ENVTEST_INSTALLED_ONLY` | ||
| env variable, which will switch that flag on by default. | ||
|
|
||
| Then, you have a few options for managing your binaries: | ||
|
|
||
| - If you don't *really* want to manage with this tool, or you want to | ||
| respect the $KUBEBUILDER_ASSETS variable if it's set to something | ||
| outside the store, use the `use --use-env -i` command. | ||
|
|
||
| `--use-env` makes the command unconditionally use the value of | ||
| KUBEBUILDER_ASSETS as long as it contains the required binaries, and | ||
| `-i` indicates that we only ever want to work with installed binaries | ||
| (no reaching out the the remote GCS storage). | ||
|
|
||
| As noted about, you can use `ENVTEST_INSTALLED_ONLY=true` to switch `-i` | ||
| on by default, and you can use `ENVTEST_USE_ENV=true` to switch | ||
| `--use-env` on by default. | ||
|
|
||
| - If you want to use this tool, but download your gziped tarballs | ||
| separately, you can use the `sideload` command. You'll need to use the | ||
| `-k/--version` flag to indicate which version you're sideloading. | ||
|
|
||
| After that, it'll be as if you'd installed the binaries with `use`. | ||
|
|
||
| - If you want to talk to some internal source, you can use the | ||
| `--remote-bucket` and `--remote-server` options. The former sets which | ||
| GCS bucket to download from, and the latter sets the host to talk to as | ||
| if it were a GCS endpoint. Theoretically, you could use the latter | ||
| version to run an internal "mirror" -- the tool expects | ||
|
|
||
| - `HOST/storage/v1/b/BUCKET/o` to return JSON like | ||
|
|
||
| ```json | ||
| {"items": [ | ||
| {"name": "kubebuilder-tools-X.Y.Z-os-arch.tar.gz", "md5Hash": "<base-64-encoded-md5-hash>"}, | ||
| {"name": "kubebuilder-tools-X.Y.Z-os-arch.tar.gz", "md5Hash": "<base-64-encoded-md5-hash>"}, | ||
| ]} | ||
| ``` | ||
|
|
||
| - `HOST/storage/v1/b/BUCKET/o/TARBALL_NAME` to return JSON like | ||
| `{"name": "kubebuilder-tools-X.Y.Z-os-arch.tar.gz", "md5Hash": "<base-64-encoded-md5-hash>"}` | ||
|
|
||
| - `HOST/storage/v1/b/BUCKET/o/TARBALL_NAME?alt=media` to return the | ||
| actual file contents | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would not first be required to move forward with #1234?
Is this one working if:
Note that currently on the KB side we can just run the tests with make test and not directly because of it. (https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v3/Makefile#L56)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an alternate approach to installing in GOBIN. We could, for instance, follow up with something along those lines where we have a well-known symlink in the store directory, and have
useorswitchchange that instead of having you fiddle with the environment variable, but I figured this was a decent first step that's backwards compatible (all CR versions support using$KUBEBUILDER_ASSETS)