Skip to content

✨ Support multiple field selectors #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

✨ Support multiple field selectors #1838

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a74b910
Support multiple field selectors
tamalsaha Mar 11, 2022
32f9776
Check generation to ensure index working on same object
tamalsaha Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Check generation to ensure index working on same object 
Signed-off-by: Tamal Saha <[email protected]>
  • Loading branch information
@tamalsaha
tamalsaha committed Mar 14, 2022
commit 32f977624f8902ae4448d42ac9cf360efd5be480
8 changes: 6 additions & 2 deletions pkg/cache/internal/cache_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,12 @@ func (c *CacheReader) List(_ context.Context, out client.ObjectList, opts ...cli
for i := range list {
obj := list[i].(client.Object)
key := client.ObjectKey{Namespace: obj.GetNamespace(), Name: obj.GetName()}
if _, exists := objmap[key]; exists {
numap[key] = obj
if o, exists := objmap[key]; exists {
if o.(client.Object).GetGeneration() == obj.GetGeneration() {
numap[key] = obj
} else {
return fmt.Errorf("multiple generation found in indices for %+v %s/%s", obj.GetObjectKind().GroupVersionKind(), obj.GetNamespace(), obj.GetName())
}
}
}
objmap = numap
Expand Down