Skip to content

🌱 Add function to controllerutil RemoveControllerReference to remove controller references from objects #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

🌱 Add function to controllerutil RemoveControllerReference to remove controller references from objects #2455

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0ae418
add function to controllerutil RemoveControllerReference
troy0820 Aug 24, 2023
7bdfa40
add more testing to assert on cases not handled
troy0820 Aug 25, 2023
08a95b1
change to use indexOwnerRef
troy0820 Aug 28, 2023
16fc13c
use actual scheme to enforce error being the object and not the scheme
troy0820 Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use actual scheme to enforce error being the object and not the scheme 
Signed-off-by: Troy Connor <[email protected]>
  • Loading branch information
@troy0820
troy0820 committed Aug 30, 2023
commit 16fc13cb88c99b160b0173bc2f457797c311b331
2 changes: 1 addition & 1 deletion pkg/controller/controllerutil/controllerutil_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ var _ = Describe("Controllerutil", func() {
}
Expect(controllerutil.SetControllerReference(dep, rs, scheme.Scheme)).NotTo(HaveOccurred())
Expect(len(rs.GetOwnerReferences())).To(BeEquivalentTo(1))
Expect(controllerutil.RemoveControllerReference(obj, rs, runtime.NewScheme())).To(HaveOccurred())
Expect(controllerutil.RemoveControllerReference(obj, rs, scheme.Scheme)).To(HaveOccurred())
Expect(len(rs.GetOwnerReferences())).To(BeEquivalentTo(1))
})
})
Expand Down