Skip to content

🐛 Suppress API server warnings in the client #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2024
Merged

🐛 Suppress API server warnings in the client #2887

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b09cb19
Allow client tests to inspect controller and client log messages
dlipovetsky Jul 23, 2024
a7baa23
Verify that client respects option to suppress warnings
dlipovetsky Jul 23, 2024
16d25f1
Correctly suppress API server warnings
dlipovetsky Jul 24, 2024
3750cad
fixup! Verify that client respects option to suppress warnings
dlipovetsky Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! Verify that client respects option to suppress warnings 
Always delete test namespace.
  • Loading branch information
@dlipovetsky
dlipovetsky committed Jul 26, 2024
commit 3750cad1ed3b87126f1744b9a43e573eb7cbd4a7
2 changes: 1 addition & 1 deletion pkg/client/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ U5wwSivyi7vmegHKmblOzNVKA5qPO8zWzqBC
tns, err = clientset.CoreV1().Namespaces().Create(ctx, tns, metav1.CreateOptions{})
Expect(err).NotTo(HaveOccurred())
Expect(tns).NotTo(BeNil())
defer deleteNamespace(ctx, tns)

toCreate := &pkg.ChaosPod{
ObjectMeta: metav1.ObjectMeta{
Expand All @@ -267,7 +268,6 @@ U5wwSivyi7vmegHKmblOzNVKA5qPO8zWzqBC
}
}
defer Fail("expected to find one API server warning in the client log")
deleteNamespace(ctx, tns)
})

It("should not log warnings when warning suppression is enabled", func() {
Expand Down