Skip to content

[release-0.20] 🌱 Handlers: Default to LowPriorityWhenUnchanged without a wrapper #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 6 commits into from
Mar 24, 2025
Merged

[release-0.20] 🌱 Handlers: Default to LowPriorityWhenUnchanged without a wrapper #3179

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5355658
🐛Implement priorityqueue as default on handlers if using priorityqueu…
troy0820 Mar 10, 2025
29debb1
:seedling: Handlers: Use low priority when object is unchanged and pr…
alvaroaleman Mar 10, 2025
2af3164
:seedling: Followups to default low priority in mappers
alvaroaleman Mar 15, 2025
2062f3a
:seedling: Remove redundant WithLowPriorityWhenUnchanged in builder
alvaroaleman Mar 21, 2025
c7d5d83
Fix godoc of TypedEventHandler
sbueringer Mar 21, 2025
9951869
:seedling: TypedRequestForOwner: Decrease priority when unchanged
alvaroaleman Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix godoc of TypedEventHandler 
Signed-off-by: Stefan Büringer [email protected]
  • Loading branch information
@sbueringer @alvaroaleman
sbueringer authored and alvaroaleman committed Mar 24, 2025
commit c7d5d83a85f695a61a8f7710a0d08705da4caf9a
2 changes: 1 addition & 1 deletion pkg/handler/eventhandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ type EventHandler = TypedEventHandler[client.Object, reconcile.Request]
//
// Unless you are implementing your own TypedEventHandler, you can ignore the functions on the TypedEventHandler interface.
// Most users shouldn't need to implement their own TypedEventHandler.

//
// TypedEventHandler is experimental and subject to future change.
type TypedEventHandler[object any, request comparable] interface {
// Create is called in response to a create event - e.g. Pod Creation.
Expand Down