⚠️ Fakeclient: Clear typemeta for structured #3229
Merged
+166
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
alvaroaleman
force-pushed
the
typemeta
branch
2 times, most recently
from
d6c17b7 to
f8773da
Compare
The fakeclient currently differs from the liveclient in that if a structured object is created that has typemeta set, it will retain that. In contrast to that, the liveclient always strips it. This change makes the fakeclient strip it just like the live client.
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a49c7a92a457cad8c7b312b1d5588225f9280bf8
|
|
/lgtm |
jcanocan
added a commit
to jcanocan/ssp-operator
that referenced
this pull request
Sep 1, 2025
The required fixed are the following: * The function RESTClientForGVK has introduced the `forceDisableProtoBuf` field. The code base has been adjusted to set this field as `false` where is is used. * Fake client now strips the TypeMeta fields kubernetes-sigs/controller-runtime#3229. Therefore, it is required to adjust how the cache gets the `Kind` field, otherwise, the field is empty and objects are not cached. Signed-off-by: Javier Cano Cano <[email protected]>
jcanocan
added a commit
to jcanocan/ssp-operator
that referenced
this pull request
Sep 1, 2025
The required fixes are the following: * The function RESTClientForGVK has introduced the `forceDisableProtoBuf` field. The code base has been adjusted to set this field as `false` where is used. * Fake client now strips the TypeMeta fields kubernetes-sigs/controller-runtime#3229. Therefore, it is required to adjust how the cache gets the `Kind` field, otherwise, the field is empty and objects are not cached. Signed-off-by: Javier Cano Cano <[email protected]>
5 tasks
|
Hello @alvaroaleman |
|
It happens in the decoder: kubernetes/kubernetes#80609 Any code that assumes presence of type meta on objects is prone to become problematic, because if someone does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fakeclient currently differs from the liveclient in that if a
structured object is created that has typemeta set, it will retain that.
In contrast to that, the liveclient always strips it.
This change makes the fakeclient strip it just like the live client.
Based on top of #3228 which needs to merge first.
Noticed this while working on #2981
/hold