Skip to content

✨ Copy all parent context values to leader elector's context #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
+6 −3
Merged

✨ Copy all parent context values to leader elector's context #3327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pkg/manager/internal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,13 +446,16 @@ func (cm *controllerManager) Start(ctx context.Context) (err error) {

// Start the leader election and all required runnables.
{
ctx, cancel := context.WithCancel(context.Background())
// Create a context that inherits all keys from the parent context
// but can be cancelled independently for leader election management
baseCtx := context.WithoutCancel(ctx)
leaderCtx, cancel := context.WithCancel(baseCtx)
cm.leaderElectionCancel = cancel
if leaderElector != nil {
// Start the leader elector process
go func() {
leaderElector.Run(ctx)
<-ctx.Done()
leaderElector.Run(leaderCtx)
<-leaderCtx.Done()
close(cm.leaderElectionStopped)
}()
} else {
Expand Down