Skip to content

🐛 wait for cache start before returning from WaitForCacheSync #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 2 commits into from
Jan 14, 2020
Merged

🐛 wait for cache start before returning from WaitForCacheSync #755

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f73674e
wait for cache start before returning from WaitForCacheSync
joelanford Jan 10, 2020
faacf85
internal/deleg_map.go: update WaitForCacheSync godoc
joelanford Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
internal/deleg_map.go: update WaitForCacheSync godoc
  • Loading branch information
@joelanford
joelanford committed Jan 14, 2020
commit faacf850c5c130c1e816823f0dc88d2369cb8430
2 changes: 1 addition & 1 deletion pkg/cache/internal/deleg_map.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func (m *InformersMap) Start(stop <-chan struct{}) error {
return nil
}

// WaitForCacheSync waits until all the caches have been synced.
// WaitForCacheSync waits until all the caches have been started and synced.
func (m *InformersMap) WaitForCacheSync(stop <-chan struct{}) bool {
syncedFuncs := append([]cache.InformerSynced(nil), m.structured.HasSyncedFuncs()...)
syncedFuncs = append(syncedFuncs, m.unstructured.HasSyncedFuncs()...)
Expand Down