Skip to content

Add namespace label selector #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
+171 −1
Draft

Add namespace label selector #1501

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2a39365
Support of the namespaceLabelSelector in DefaultEvictor plugin
RomanenkoDenys Aug 22, 2024
23b00be
Support of the namespaceLabelSelector in DefaultEvictor plugin
RomanenkoDenys Sep 4, 2024
f2b36a3
Support of the namespaceLabelSelector in DefaultEvictor plugin
RomanenkoDenys Sep 4, 2024
03983e5
Support of the namespaceLabelSelector in DefaultEvictor plugin
RomanenkoDenys Sep 4, 2024
bfacd76
Support of the namespaceLabelSelector in DefaultEvictor
RomanenkoDenys Oct 28, 2024
f8de9f8
Support of the namespaceLabelSelector in DefaultEvictor
RomanenkoDenys Oct 28, 2024
d7fb631
Support of the namespaceLabelSelector in DefaultEvictor
RomanenkoDenys Oct 28, 2024
3adaea9
Support of the namespaceLabelSelector in DefaultEvictor
RomanenkoDenys Oct 28, 2024
0dd74d4
Support of the namespaceLabelSelector in DefaultEvictor
RomanenkoDenys Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support of the namespaceLabelSelector in DefaultEvictor plugin
  • Loading branch information
@RomanenkoDenys
RomanenkoDenys committed Oct 28, 2024
commit 23b00be3c461db9f123c7b0eca7acab81c97b680
4 changes: 1 addition & 3 deletions pkg/framework/plugins/defaultevictor/defaultevictor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,12 +230,11 @@ func (d *DefaultEvictor) PreEvictionFilter(pod *v1.Pod) bool {
klog.InfoS("pod does not fit on any other node because of nodeSelector(s), Taint(s), or nodes marked as unschedulable", "pod", klog.KObj(pod))
return false
}
return true
}

// check pod by namespace label filter
if d.args.NamespaceLabelSelector != nil {
indexName := "metadata.namespace"
indexName := "namespaceWithLabelSelector"
indexer, err := getNamespacesListByLabelSelector(indexName, d.args.NamespaceLabelSelector, d.handle)
if err != nil {
klog.ErrorS(err, "unable to list namespaces", "pod", klog.KObj(pod))
Expand All @@ -250,7 +249,6 @@ func (d *DefaultEvictor) PreEvictionFilter(pod *v1.Pod) bool {
klog.InfoS("pod namespace do not match the namespaceLabelSelector filter in the policy parameter", "pod", klog.KObj(pod))
return false
}
return true
}

return true
Expand Down