Skip to content

refactor: remove unused code#471

Merged
k8s-ci-robot merged 3 commits into
kubernetes-sigs:masterfrom
Kevinz857:master
Dec 16, 2020
Merged

refactor: remove unused code#471
k8s-ci-robot merged 3 commits into
kubernetes-sigs:masterfrom
Kevinz857:master

Conversation

@Kevinz857
Copy link
Copy Markdown
Contributor

@Kevinz857 Kevinz857 commented Dec 12, 2020 •
edited
Loading

/kind design

ReadyNodes's parm about 'stopChannel' is not being used

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 12, 2020

@Mathew857: The label(s) kind/desgin cannot be applied, because the repository doesn't have them

Details

In response to this:

/kind desgin

ReadyNodes's parm about 'stopChannel' is not being used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 12, 2020

Welcome @Mathew857!

It looks like this is your first PR to kubernetes-sigs/descheduler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/descheduler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 12, 2020

Hi @Mathew857. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2020
@Kevinz857
Copy link
Copy Markdown
Contributor Author

Kevinz857 commented Dec 12, 2020 •
edited
Loading

/assign @damemi

please help review when you are free, thanks a lot

damemi
damemi approved these changes Dec 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
good find, looks like this was missed when we updated the node informer code in this commit: 9593ce1#diff-fc4033754cd376d78b09ff84a934296f26e774702505885309268f816ba3817c

@damemi
Copy link
Copy Markdown
Member

damemi commented Dec 14, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 14, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, Mathew857

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
@damemi
Copy link
Copy Markdown
Member

damemi commented Dec 14, 2020

@Mathew857 looks like you also need to update the test files:

 # sigs.k8s.io/descheduler/pkg/descheduler/node [sigs.k8s.io/descheduler/pkg/descheduler/node.test]
pkg/descheduler/node/node_test.go:77:24: too many arguments in call to ReadyNodes
	have (context.Context, *"k8s.io/client-go/kubernetes/fake".Clientset, "k8s.io/client-go/informers/core/v1".NodeInformer, string, nil)
	want (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string)

@Kevinz857
Copy link
Copy Markdown
Contributor Author

Kevinz857 commented Dec 15, 2020

/assign @damemi

node_test file updated, pls check it if you are free, thanks a lot

@Kevinz857 Kevinz857 requested a review from damemi December 15, 2020 13:44
@Kevinz857
Copy link
Copy Markdown
Contributor Author

Kevinz857 commented Dec 15, 2020

/retest

@Kevinz857
Copy link
Copy Markdown
Contributor Author

Kevinz857 commented Dec 15, 2020

should I also refactor about node informer code in client-go ? @damemi

"skipped 213 lines unfold_more
have (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string, nil)
want (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string)
test/e2e/e2e_test.go:197:35: too many arguments in call to "sigs.k8s.io/descheduler/pkg/descheduler/node".ReadyNodes
have (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string, nil)
want (context.Context, kubernetes.Interface, "k8s.io/client-go/informers/core/v1".NodeInformer, string)"

@damemi
Copy link
Copy Markdown
Member

damemi commented Dec 15, 2020

@Mathew857 that error looks to just be a similar one, this time in test/e2e/e2e_test.go, just need to remove this param from ReadyNodes there too

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2020
@Kevinz857
Copy link
Copy Markdown
Contributor Author

Kevinz857 commented Dec 16, 2020

@Mathew857 that error looks to just be a similar one, this time in test/e2e/e2e_test.go, just need to remove this param from ReadyNodes there too

thanks reminder

lixiang233
lixiang233 reviewed Dec 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lixiang233 lixiang233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit f54df67 into kubernetes-sigs:master Dec 16, 2020
@seanmalloy
Copy link
Copy Markdown
Member

seanmalloy commented Dec 17, 2020

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 17, 2020
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#471 from Mathew857/master
34bff35 
refactor: remove unused code
ingvagabund added a commit to ingvagabund/descheduler that referenced this pull request Mar 12, 2026
@ingvagabund
Merge pull request kubernetes-sigs#471 from ingvagabund/release-4.19
712f5d8 
CNTRLPLANE-2844: chore(plan ahead): prepare for 5.2.2 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@damemi damemi Awaiting requested review from damemi

1 more reviewer

@lixiang233 lixiang233 lixiang233 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@damemi damemi

@lixiang233 lixiang233

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kevinz857 @k8s-ci-robot @damemi @seanmalloy @lixiang233