Skip to content

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented May 25, 2025

What does it do ?

Motivation

I was looking at issues, example

Most of them related timeouts. This PR is not a fix for any of them. There is a flag https://github.com/kubernetes-sigs/external-dns/blob/36bc7d6bc47d4d8862aa02f88ac57d0608919a2a/docs/flags.md?plain=1#L12C1-L12C2 --request-timeout=, but the config is not respected, the timeout is static.

In this PR I've

  • added more unit tests
  • moved cache to dedicated folder
  • different source do use different aliases for imports, fixed this
  • added more units tests

This will simplify in follow-up to

  • support sync request timeout in cache sync with the flag
  • will simplify in fiture to move sources to specific folders
  • create an interface, to simplify unit testing

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot requested review from mloiseleur and szuecs May 25, 2025 12:55
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2025
@mloiseleur
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 60bfa07 into kubernetes-sigs:master May 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants