Skip to content

Fix import #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2019
Merged

Fix import #1130

merged 2 commits into from
Oct 28, 2019

Conversation

@camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Oct 25, 2019 •
edited
Loading

Description
Add missing import.

Motivation
Closes: #1119

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2019
@camilamacedo86 camilamacedo86 mentioned this pull request Oct 25, 2019
Closed
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Oct 25, 2019

c/c @mengqiy, @droot and @Adirio.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2019
@droot
Copy link
Contributor

droot commented Oct 25, 2019

Looks good to me. Pl. combine the last two commits, then its good to go.

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Oct 25, 2019

Done @droot :-)

@Adirio
Copy link
Contributor

Adirio commented Oct 28, 2019 •
edited
Loading

This was already being tackled in #1120. In case this is merged before the other, rebase the other.

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Oct 28, 2019

Adirio, this PR in oder to solve it and help you since you are facing issues to use the golden script.

@camilamacedo86 camilamacedo86 mentioned this pull request Oct 28, 2019
Merged
Adirio
Adirio reviewed Oct 28, 2019
View reviewed changes
Makefile
generate-setup: ## Current workarround to generate the testdata with the correct controller-gen version
- rm -rf $(CONTROLLER_GEN_BIN_PATH)
- GO111MODULE=on go get sigs.k8s.io/controller-tools/cmd/[email protected].1
- GO111MODULE=on go get sigs.k8s.io/controller-tools/cmd/[email protected].2
Copy link
Contributor

@Adirio Adirio Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be part of a different PR? Bumping controller-gen to v0.2.2 doesn't seem related to the import fix.

Copy link
Member Author

@camilamacedo86 camilamacedo86 Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Adirio, the command make generate-setup is just a helper for development purpose. We can use it before exec the golden script to ensure that the correct version of the controller-gen will be used. So, it is a very small update and since it is too small I believe that would be ok be in this PR.

@droot droot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 28, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 51b5360 into kubernetes-sigs:master Oct 28, 2019
@camilamacedo86 camilamacedo86 deleted the fix-import branch October 28, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

1 more reviewer

@Adirio Adirio Adirio left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing import in scaffolded code

4 participants

@camilamacedo86 @droot @Adirio @k8s-ci-robot