Skip to content

Conversation

@estroz
Copy link
Contributor

@estroz estroz commented Mar 20, 2020

So Config.Version does not also need to be updated when DefaultVersion is changed in the future.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2020
@estroz
Copy link
Contributor Author

estroz commented Mar 20, 2020

/cc @Adirio

@k8s-ci-robot k8s-ci-robot requested review from Adirio and mengqiy March 20, 2020 22:40
@estroz estroz changed the title internal/config/config.go: use DefaultVersion instead config.Version2 internal/config/config.go: use DefaultVersion instead of config.Version2 Mar 20, 2020
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense 👍

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 21, 2020
@camilamacedo86
Copy link
Member

/lgtm cancel
/approve cancel

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 21, 2020
@camilamacedo86
Copy link
Member

HI @estroz
It is just a replacement for the constant. (too small) Should not break the CI.
I will be looking at it.

@camilamacedo86
Copy link
Member

camilamacedo86 commented Mar 21, 2020

Confirmed that it is a Trevi's incident. See: https://travis-ci.org/github/kubernetes-sigs/kubebuilder/builds/665054120?utm_source=github_status&utm_medium=notification

Also, check it locally and all worked fine as expected since it is just a small change to use the var instead of.

/lgtm
/approve

When the incident be solved jut re-trigger the Travis job and then, it will be merged.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8b53abe into kubernetes-sigs:master Mar 21, 2020
@estroz estroz deleted the bugfix/correct-default-version branch March 21, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants