-
Notifications
You must be signed in to change notification settings - Fork 1.6k
internal/config/config.go: use DefaultVersion instead of config.Version2
#1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/config/config.go: use DefaultVersion instead of config.Version2
#1440
Conversation
|
/cc @Adirio |
DefaultVersion instead config.Version2DefaultVersion instead of config.Version2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense 👍
|
/lgtm cancel |
|
HI @estroz |
|
Confirmed that it is a Trevi's incident. See: https://travis-ci.org/github/kubernetes-sigs/kubebuilder/builds/665054120?utm_source=github_status&utm_medium=notification Also, check it locally and all worked fine as expected since it is just a small change to use the var instead of. /lgtm When the incident be solved jut re-trigger the Travis job and then, it will be merged. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
So
Config.Versiondoes not also need to be updated whenDefaultVersionis changed in the future.