⚠️ change structure to store crdVersion and webhookversion (go/v3-alpha) #1899
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
camilamacedo86
force-pushed
the
fix-crd-web-version
branch
from
730a830 to
32de34f
Compare
|
/test pull-kubebuilder-e2e-k8s-1-18-0 |
|
I think I'm ok with this. Going to wait for an ack from someone else. /approve |
Adirio
left a comment
Adirio
left a comment
There was a problem hiding this comment.
While the Resource and the Config models need some cleanup, this PR moves the previously existing fields to their correct location, which means that the rest of the changes that are to be done in the near future will not be breaking changes from a project configutaion file perspective, so
\lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
prafull11
left a comment
prafull11
left a comment
There was a problem hiding this comment.
Just a nit in the comment. Apart from that LGTM
pkg/model/config/config.go
Outdated
| } | ||
| } | ||
|
|
||
| // merge compares it with another webhook by setting each webhook type individually so existing values are |
There was a problem hiding this comment.
| // merge compares it with another webhook by setting each webhook type individually so existing values are | |
| // merge compares it with another api by setting each api type individually so existing values are |
camilamacedo86
force-pushed
the
fix-crd-web-version
branch
from
32de34f to
90a7ad3
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-kubebuilder-e2e-k8s-1-16-2 |
6 participants
Description
Only does the changes required to store the new attributes crdVersion and webhookVersion in the format/layout define on #1772 and #1826.
Motivation