Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
dab613d
This commit stabilizes plugin go/v3-alpha to go/v3 and makes it
estroz Dec 3, 2020
a08bbfb
Fix the path of probes
zoetrope Dec 14, 2020
6e1f8d0
Merge pull request #1905 from zoetrope/fix-probe
k8s-ci-robot Dec 14, 2020
0a807f4
Merge pull request #1882 from estroz/feature/stabilize-go-v3
k8s-ci-robot Dec 14, 2020
7dc4d33
:sparkles: add new extension to markers in order to allow work with .yml
camilamacedo86 Dec 15, 2020
a4ad49a
Merge pull request #1907 from camilamacedo86/add-marker-extension
k8s-ci-robot Dec 15, 2020
90a7ad3
:warning: change structure to store crdVersion and webhkversion (go/v…
camilamacedo86 Dec 11, 2020
762211a
Merge pull request #1899 from camilamacedo86/fix-crd-web-version
k8s-ci-robot Dec 15, 2020
e604838
sparkles: (go/v3-alpha) Add the --force option for the webhook
prafull01 Dec 15, 2020
bba9577
Merge pull request #1903 from prafull01/force-webhook
k8s-ci-robot Dec 15, 2020
258470c
:sparkles: Add the unit tests for HasWebhook
prafull01 Dec 16, 2020
c9114ed
Merge pull request #1909 from prafull01/config-unit-test
k8s-ci-robot Dec 16, 2020
0c02833
:bug: Fix --force option to recreate the files by kubebuilder create api
prafull01 Nov 19, 2020
a4d0a3a
Merge pull request #1847 from prafull01/kb-force
k8s-ci-robot Dec 16, 2020
9ee7a30
Remove spaces from machine-readable comments (v3 only)
Adirio Dec 2, 2020
7245d41
Merge pull request #1868 from Adirio/machine-readable-markers
k8s-ci-robot Dec 17, 2020
6cf73c3
:book: update the docs by removng--plugin=v3/alpha since it no longer…
camilamacedo86 Dec 18, 2020
65f9853
:book: update samples
camilamacedo86 Dec 18, 2020
948887a
Merge pull request #1918 from camilamacedo86/update-docs-testdata-v3
k8s-ci-robot Dec 18, 2020
0082e95
:book: add info to tutorial about apis with examples
camilamacedo86 Dec 18, 2020
ea7e28e
Merge pull request #1920 from camilamacedo86/api-doc-add-info
k8s-ci-robot Dec 21, 2020
8097960
:seedling: Move the license year to 2021 in testdata
prafull01 Jan 5, 2021
23b7082
Merge pull request #1929 from prafull01/copyright-year
k8s-ci-robot Jan 5, 2021
aa9c2e0
Use lowered resource kind as file name
south37 Dec 29, 2020
f660017
Merge pull request #1927 from south37/use-lowered-resource-kind-as-fi…
k8s-ci-robot Jan 6, 2021
26d7b42
Merge pull request #1919 from camilamacedo86/fix-doc-v3-stable
k8s-ci-robot Jan 7, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
This commit stabilizes plugin go/v3-alpha to go/v3 and makes it
the default plugin.

cmd/main.go: make go/v3 the default plugin

*: update tests to create projects for the correct plugin version
  • Loading branch information
estroz committed Dec 5, 2020
commit dab613d00e274c18056763001870dd3032b7b851
8 changes: 2 additions & 6 deletions cmd/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,8 @@ func main() {
&pluginv2.Plugin{},
&pluginv3.Plugin{},
),
cli.WithDefaultPlugins(config.Version2,
&pluginv2.Plugin{},
),
cli.WithDefaultPlugins(config.Version3Alpha,
&pluginv2.Plugin{},
),
cli.WithDefaultPlugins(config.Version2, &pluginv2.Plugin{}),
cli.WithDefaultPlugins(config.Version3Alpha, &pluginv3.Plugin{}),
cli.WithCompletion,
)
if err != nil {
Expand Down
14 changes: 8 additions & 6 deletions generate_testdata.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ scaffold_test_project() {
cd testdata/$project
local kb=$testdata_dir/../bin/kubebuilder

# Remove tool binaries for non-plugin projects, which don't have locally-configured binaries,
# Remove tool binaries for projects of version 2, which don't have locally-configured binaries,
# so the correct versions are used.
if [[ ! $init_flags =~ --plugins ]]; then
if [[ $init_flags =~ --project-version=2 ]]; then
rm -f "$(command -v controller-gen)"
rm -f "$(command -v kustomize)"
fi
Expand Down Expand Up @@ -106,10 +106,12 @@ export GO111MODULE=on
export PATH="$PATH:$(go env GOPATH)/bin"

build_kb
# Project version 2 uses plugin go/v2 (default).
scaffold_test_project project-v2 --project-version=2
scaffold_test_project project-v2-multigroup --project-version=2
scaffold_test_project project-v2-addon --project-version=2
scaffold_test_project project-v3 --project-version=3-alpha --plugins=go/v3-alpha
scaffold_test_project project-v3-multigroup --project-version=3-alpha --plugins=go/v3-alpha
scaffold_test_project project-v3-addon --project-version=3-alpha --plugins=go/v3-alpha
scaffold_test_project project-v3-config --project-version=3-alpha --plugins=go/v3-alpha --component-config
# Project version 3 (default) uses plugin go/v3 (default).
scaffold_test_project project-v3
scaffold_test_project project-v3-multigroup
scaffold_test_project project-v3-addon
scaffold_test_project project-v3-config --component-config
2 changes: 1 addition & 1 deletion pkg/plugins/golang/v3/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const pluginName = "go" + plugins.DefaultNameQualifier

var (
supportedProjectVersions = []string{config.Version3Alpha}
pluginVersion = plugin.Version{Number: 3, Stage: plugin.AlphaStage}
pluginVersion = plugin.Version{Number: 3}
)

var _ plugin.Full = Plugin{}
Expand Down
1 change: 1 addition & 0 deletions test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -155,5 +155,6 @@ test_project project-v2-addon 2
test_project project-v3 3-alpha
test_project project-v3-multigroup 3-alpha
test_project project-v3-addon 3-alpha
test_project project-v3-config 3-alpha

exit $rc
7 changes: 4 additions & 3 deletions test/e2e/v3/generate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@ import (
func GenerateV2(kbc *utils.TestContext) {
var err error

By("initializing a v3 project")
By("initializing a project")
err = kbc.Init(
"--project-version", "3-alpha",
"--plugins", "go/v2",
"--domain", kbc.Domain,
"--fetch-deps=false",
)
Expand Down Expand Up @@ -126,10 +127,10 @@ Count int `+"`"+`json:"count,omitempty"`+"`"+`
func GenerateV3(kbc *utils.TestContext, crdAndWebhookVersion string) {
var err error

By("initializing a v3 project")
By("initializing a project")
err = kbc.Init(
"--plugins", "go/v3-alpha",
"--project-version", "3-alpha",
"--plugins", "go/v3",
"--domain", kbc.Domain,
"--fetch-deps=false",
)
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v3-addon/PROJECT
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
domain: testproject.org
layout: go.kubebuilder.io/v3-alpha
layout: go.kubebuilder.io/v3
projectName: project-v3-addon
repo: sigs.k8s.io/kubebuilder/testdata/project-v3-addon
resources:
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v3-config/PROJECT
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
componentConfig: true
domain: testproject.org
layout: go.kubebuilder.io/v3-alpha
layout: go.kubebuilder.io/v3
projectName: project-v3-config
repo: sigs.k8s.io/kubebuilder/testdata/project-v3-config
resources:
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v3-multigroup/PROJECT
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
domain: testproject.org
layout: go.kubebuilder.io/v3-alpha
layout: go.kubebuilder.io/v3
multigroup: true
projectName: project-v3-multigroup
repo: sigs.k8s.io/kubebuilder/testdata/project-v3-multigroup
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v3/PROJECT
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
domain: testproject.org
layout: go.kubebuilder.io/v3-alpha
layout: go.kubebuilder.io/v3
projectName: project-v3
repo: sigs.k8s.io/kubebuilder/testdata/project-v3
resources:
Expand Down