🌱 Update release-3 for v3.0.0-beta.0 #2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message if the path to CRDs is missing is misleading. envtest.Environment has an option to throw a sensible error here if the path is wrong and for kubebuilder it would be likely we always want to upload our CRDs.
dep is no longer used by the project (we use go mod instead); remove the help test that suggests we will suggest it.
✨ Remove misleading help that mentioned dep
…d help message is printed Signed-off-by: Adrian Orive <[email protected]>
… v1.19 equivalent tag
✨ (go/v3) upgrade kubebuilder-declarative-pattern to k8s v1.19
When I encountered the error, I had to go to the source to understand the problem. Made the message more user-focused. Also skipped printing the allowlist, both to fit into lint line-length limits and to avoid overwhelming the user.
✨ Add help dialog to makefile template
✨ Make directory-not-empty error more self-explanatory
✨ Build the command and use it to report user errors
✨ rename probes endpoints (go/v3)
⚠️ upgrade kubebuilder module from v2 to v3
Signed-off-by: Eric Stroczynski <[email protected]>
✨ *: upgrade kube-rbac-proxy to v0.8.0
✨ Use ErrorIfCRDPathMissing in EnvTest
…ce for better project version maintanability Signed-off-by: Adrian Orive <[email protected]>
⚠ Update models
Adds the flags and the required marker to the types file. Signed-off-by: Adrian Orive Oneca <[email protected]>
⚠ Add --plural flag (go/v3)
Signed-off-by: Adrian Orive Oneca <[email protected]>
🐛 Validate the plugin flag
…t Resources built in different ways can still be validated Signed-off-by: Adrian Orive <[email protected]>
Signed-off-by: Adrian Orive Oneca <[email protected]>
…ot: true' Signed-off-by: Eric Stroczynski <[email protected]>
✨ (go/v3) change 'runAsUser: 65532' to 'runAsNonRoot: true'
Signed-off-by: Adrian Orive <[email protected]>
📖 upgrade migration guide for v3
Made an list that makes it easy to add new files to the allowed list with their justification Signed-off-by: Adrian Orive Oneca <[email protected]>
✨ Accept auto-generated files from GitHub into the allowed set of files
🌱 Add Adirio to aprovers
🌱 Tests cleanup
📖 proposal for new plugin to generate code ( `deploy-image.go.kubebuilder.io/v1beta1` )
…ag not being recognized by the root command Signed-off-by: Adrian Orive <[email protected]>
🐛 Fix the bug where an error was being hidden by a potentially valid flag not being recognized by the root command
📖 Update static book examples to Kubebuilder v3.
Signed-off-by: Adrian Orive <[email protected]>
🌱 Enable cross-package coverage
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
the
cncf-cla: yes
camilamacedo86
approved these changes
Feb 18, 2021
Member
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
This is the same as #2008 + the latest changes directly from the master. (without a fork)
It was previously approved by solly, me and eric
/lgtm
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the local branch
masterintorelease-3in preparation forv3.0.0-beta.0Closes: #2008