🌱 Enhance GitHub actions CI #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
Contributor
Author
|
@estroz |
Adirio
force-pushed
the
enhance-gh-actions
branch
from
ec2e337 to
6bb439c
Compare
estroz
reviewed
Mar 16, 2021
Contributor
Author
|
Another example of this "hidden"/"quiet" fails occured with #2060 and we only realized when merging |
Adirio
force-pushed
the
enhance-gh-actions
branch
from
6bb439c to
eadb5aa
Compare
Signed-off-by: Adrian Orive <[email protected]>
Adirio
force-pushed
the
enhance-gh-actions
branch
from
eadb5aa to
9abe27b
Compare
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub actions CI workflow is run for both pull-requests (targeting the remote branch) and the merge commit push whey they re merged (targeting the branch where they were merged into). Pull-request-related results are exposed under the checks of the PR, which makes them pretty accessible. However, push-related results are only shown in the "Actions" tab and are usually not reviewed. As an example, a linting issue was introduced nearlly a month ago in master, which was passing the PR linting check as it only checks the modified code, but was not passing the push linting check. This means that coverage report was not being sent to coveralls about the master branch since the February 22nd, and we just realized today (March 16th).
This PR adds an additional debugging step that will create an issue if one of the "hidden" GitHub action CI workflows fail with the SHA of the offending commit, the link to the corresponding action execution wher some debugging information will alos be found (secrets are safely removed first).