✨ add default conversion review versions #2176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Member
Author
|
cc: @estroz |
estroz
reviewed
May 10, 2021
estroz
reviewed
May 10, 2021
estroz
reviewed
May 10, 2021
...s/common/kustomize/v1/scaffolds/internal/templates/config/crd/patches/enablewebhook_patch.go
Outdated
Show resolved
Hide resolved
2 tasks
varshaprasad96
force-pushed
the
add/default-convReviewVersions
branch
from
ef7f789 to
ffd6e75
Compare
k8s-ci-robot
added
size/M
varshaprasad96
commented
May 10, 2021
k8s-ci-robot
added
do-not-merge/hold
estroz
reviewed
May 11, 2021
varshaprasad96
force-pushed
the
add/default-convReviewVersions
branch
from
ffd6e75 to
2805b11
Compare
The conversion webhook client config requires a list of conversion review versions. This change scaffolds the conversion webhook patch with default conversion review version of v1. Signed-off-by: varshaprasad96 <[email protected]>
varshaprasad96
force-pushed
the
add/default-convReviewVersions
branch
from
2805b11 to
e5f095b
Compare
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion webhook client config requires a list
of conversion review versions. This change scaffolds the
conversion webhook patch with default conversion review version
of v1.