Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
✨ add default conversion review versions
The conversion webhook client config requires a list
of conversion review versions. This change scaffolds the
conversion webhook patch with default conversion review version
of v1.

Signed-off-by: varshaprasad96 <[email protected]>
  • Loading branch information
varshaprasad96 committed May 11, 2021
commit e5f095b9a562ea955f9f6c79a11daf409ed3645a
1 change: 1 addition & 0 deletions pkg/cli/alpha/config-gen/cert-generation-filter.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ type CertFilter struct {
}

// Filter implements kio.Filter
// TODO: when v1 CRDs are supported, scaffold conversion webhook versions.
func (c CertFilter) Filter(input []*yaml.RNode) ([]*yaml.RNode, error) {

if c.Spec.Webhooks.CertificateSource.Type != "dev" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,7 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- {{ .Resource.API.CRDVersion }}
{{- end }}
`
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec:
namespace: system
name: webhook-service
path: /convert
conversionReviewVersions:
- v1