Skip to content

🌱 Bump the linter version #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2021
Merged

🌱 Bump the linter version #2275

merged 1 commit into from
Aug 11, 2021

Conversation

@davidlanouette
Copy link
Contributor

@davidlanouette davidlanouette commented Jul 29, 2021

Description

Update the version of golangci-lint to the latest version.

This change updates both the version that is downloaded, the config file to account for deprecated linters in 1.41, and fixes some issues found by revive (which replaces golint.)

make lint and make test both pass with no issues.

Motivation

Although the version in current use isn't "old", there are some linters that aren't maintained anymore, or have been supersededded by other linters.

The thought is that the latest version will be more likely to catch more "issues" - before they make it into a release.

Fixes

Fixes #2274

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 29, 2021

Welcome @davidlanouette!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 29, 2021

Hi @davidlanouette. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2021
@davidlanouette davidlanouette changed the title Bump the linter version Non-breaking feature: Bump the linter version Jul 29, 2021
@davidlanouette davidlanouette changed the title Non-breaking feature: Bump the linter version Infra/Tests/Other: Bump the linter version Jul 29, 2021
@davidlanouette davidlanouette changed the title Infra/Tests/Other: Bump the linter version 🌱 Bump the linter version Jul 29, 2021
@davidlanouette davidlanouette changed the title 🌱 Bump the linter version Infra/Tests/Other: 🌱 Bump the linter version Jul 29, 2021
@davidlanouette davidlanouette changed the title Infra/Tests/Other: 🌱 Bump the linter version Infra/Tests/Other: Bump the linter version Jul 29, 2021
@davidlanouette davidlanouette changed the title Infra/Tests/Other: Bump the linter version Infra/Tests/Other: 🌱 Bump the linter version Jul 29, 2021
@davidlanouette davidlanouette changed the title Infra/Tests/Other: 🌱 Bump the linter version 🌱 Bump the linter version Jul 29, 2021
@davidlanouette
Copy link
Contributor Author

davidlanouette commented Jul 29, 2021

/assign @estroz

davidlanouette
davidlanouette commented Jul 29, 2021
View reviewed changes
.golangci.yml
- gosimple
- govet
- ineffassign
- interfacer
Copy link
Contributor Author

@davidlanouette davidlanouette Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARN [runner] The linter 'interfacer' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner

.golangci.yml
- gocyclo
- gofmt
- goimports
- golint
Copy link
Contributor Author

@davidlanouette davidlanouette Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive.

.golangci.yml
- misspell
- nakedret
- prealloc
- scopelint
Copy link
Contributor Author

@davidlanouette davidlanouette Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARN [runner] The linter 'scopelint' is deprecated (since v1.39.0) due to: The repository of the linter has been deprecated by the owner. Replaced by exportloopref.

.golangci.yml
- ineffassign
- interfacer
- lll
- maligned
Copy link
Contributor Author

@davidlanouette davidlanouette Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARN [runner] The linter 'maligned' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner. Replaced by govet 'fieldalignment'.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2021
@estroz
Copy link
Contributor

estroz commented Jul 29, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2021
@davidlanouette
Copy link
Contributor Author

davidlanouette commented Aug 10, 2021

bump.

@camilamacedo86 or @joelanford Can I get a post-checks review for this?

@estroz
Copy link
Contributor

estroz commented Aug 10, 2021

@davidlanouette can you squash your commits? Then I'll approve.

@davidlanouette
Copy link
Contributor Author

davidlanouette commented Aug 10, 2021

@estroz I've squashed all commits into 1.

Thanks for the review help!

@davidlanouette
Copy link
Contributor Author

davidlanouette commented Aug 10, 2021

OOPS. looks like I have a little bit more work to do...

@estroz I'll ping you again once I've addressed that failed job.

@estroz
Copy link
Contributor

estroz commented Aug 11, 2021

/retest

@davidlanouette
Copy link
Contributor Author

davidlanouette commented Aug 11, 2021

@estroz It looks like the retest did the trick.

I think it only needs an lgtm, and she's good to go.

@estroz
Copy link
Contributor

estroz commented Aug 11, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidlanouette, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021
@estroz
Copy link
Contributor

estroz commented Aug 11, 2021

@davidlanouette thanks for the submission!

@k8s-ci-robot k8s-ci-robot merged commit 2b3a589 into kubernetes-sigs:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@joelanford joelanford Awaiting requested review from joelanford

1 more reviewer

@estroz estroz estroz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@estroz estroz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump the version of golangci-lint to v1.41.1

3 participants

@davidlanouette @k8s-ci-robot @estroz