Skip to content

Conversation

@camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Oct 29, 2021

Description

  • Rebase master and solve conflict with the Owner alias

w3st3ry and others added 30 commits April 28, 2021 14:23
- create apidiff.yaml in github workflows
- Added `apidiff` target to Makefile for local testing
- Always compare with master for any api differences
- Invoke tests in CI only on pull_request from a different repo
🌱  add go-apidiff to verify api differences
…es-whitelist

✨ Extend files whitelist for init cmd
Several comments for enabling cert-manager in the kustomization config
incorrectly said `[CERTMANAGER] To enable webhook`

This was probably a copy/paste error.
🐛 fix: incorrect cert-manager kustomize comments
Replace broken Travis CI badge in README with GitHub Lint & Unit Test actions
Run `go mod tidy` before building image so the go.mod has
the required deps.

See https://blog.golang.org/go116-module-changes#TOC_3.
🐛 Refactor `alpha config-gen` to use embed from go 1.16
🐛 update config-gen to match v3 expectations
Add v1alpha1 to the apiVersion
🐛 Update kubernetes-sigs/controller-tools to v0.5.0
📖 Link to v2 book as well from intro page
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2021
@camilamacedo86
Copy link
Member Author

/override deleted-job cla/linuxfoundation

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: camilamacedo86 unauthorized: /override is restricted to Repo administrators.

In response to this:

/override deleted-job cla/linuxfoundation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@camilamacedo86
Copy link
Member Author

/override cla/linuxfoundation

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: camilamacedo86 unauthorized: /override is restricted to Repo administrators.

In response to this:

/override cla/linuxfoundation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 29, 2021
@camilamacedo86
Copy link
Member Author

I forced cla label since it seems a bug.

@estroz
Copy link
Contributor

estroz commented Oct 29, 2021

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2021
@estroz
Copy link
Contributor

estroz commented Oct 29, 2021

/override cla/linuxfoundation

@k8s-ci-robot
Copy link
Contributor

@estroz: Overrode contexts on behalf of estroz: cla/linuxfoundation

In response to this:

/override cla/linuxfoundation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 29, 2021
@estroz estroz merged commit b7a730c into kubernetes-sigs:release-3 Oct 29, 2021
@camilamacedo86 camilamacedo86 deleted the release-3 branch October 29, 2021 16:10
@camilamacedo86 camilamacedo86 added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.