Skip to content

Conversation

@dmvolod
Copy link
Member

@dmvolod dmvolod commented Nov 25, 2021

It would be nice t remove containsString helper function from the docs/book/src/cronjob-tutorial/testdata/finalizer_example.go and utilize controllerutil.ContainsFinalizer instead. Many newcomers copy/paste this example into the code, but it a bit stale/redundant.

fixes #2425

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 25, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @dmvolod!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @dmvolod. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2021
@dmvolod dmvolod changed the title book Utilize controllerutil.ContainsFinalizer inside kubebuilder book CronJob finalizer example book: Utilize controllerutil.ContainsFinalizer inside kubebuilder book CronJob finalizer example Nov 25, 2021
@dmvolod dmvolod changed the title book: Utilize controllerutil.ContainsFinalizer inside kubebuilder book CronJob finalizer example Utilize controllerutil.ContainsFinalizer inside kubebuilder book CronJob finalizer example Nov 25, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 25, 2021
@dmvolod dmvolod changed the title Utilize controllerutil.ContainsFinalizer inside kubebuilder book CronJob finalizer example 📖 Utilize controllerutil.ContainsFinalizer inside kubebuilder book CronJob finalizer example Nov 25, 2021
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for the contribution 🥇

/approved
/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, dmvolod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2021
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-14-10

@k8s-ci-robot k8s-ci-robot merged commit e51c785 into kubernetes-sigs:master Nov 28, 2021
@dmvolod dmvolod deleted the issue-2425 branch January 21, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Utilize controllerutil.ContainsFinalizer inside kubebuilder book CronJob finalizer example

3 participants