-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🌱: upgrade docker image for darwin to 1.17 #2476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱: upgrade docker image for darwin to 1.17 #2476
Conversation
Signed-off-by: ankitm123 <[email protected]>
|
Hi @ankitm123. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @camilamacedo86 |
|
/ok-to-test |
|
I could check that the PR: #2456 updated this branch to use 1.23 and it is missing the artefact for mac os x see: https://storage.googleapis.com/kubebuilder-tools /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitm123, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ankitm123 [email protected]
Blocks #2471 .
The issue is ENVTEST_K8S_VERSION is set to 1.23 in all testdata makefiles, but darwin binaries are missing for that version.
I think the issue could be that the last cloudbuild pipeline failed because of timeout? I am not sure ...