-
Notifications
You must be signed in to change notification settings - Fork 1.6k
📖 Update go prerequisites for the 3.3 release #2489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update go prerequisites for the 3.3 release #2489
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
|
|
Welcome @antonincms! |
|
Hi @antonincms. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, you need to assign the SLA so we are able to move forward.
Also, can you please address the nits and squash the commits?
Btw, really tks for the contribution 🥇
Yes, I am working on it.
Of course ! |
Also updated old prerequisites for better clarity. Co-authored-by: Camila Macedo <[email protected]>
|
It should be good now. |
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approved
Thank you 🥇
Could you please also do a cherry-pick to the book-v3 branch?
Otherwise, these changes will not be reflected in the website before the next release.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: antonincms, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
Done, and thank you for helping 👍 |
This PR fixes #2488 by documenting in the kubebuilder book that releases 3.3 and above need go v1.17 and above.
(It seems my vscode also removed some spaces, I could cancel that part).