Skip to content

🌱 grafana/v1-alpha: correct title and description syntax #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2022
Merged

🌱 grafana/v1-alpha: correct title and description syntax #2847

merged 1 commit into from
Aug 3, 2022

Conversation

@Kavinjsir
Copy link
Contributor

@Kavinjsir Kavinjsir commented Jul 29, 2022

Description

Correct syntax of Grafana dashboards titles and descriptions.

Motivation

Apply nits in #2834 .

Fix #2846 .

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 29, 2022

Hi @Kavinjsir. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2022
@Kavinjsir Kavinjsir mentioned this pull request Jul 29, 2022
Closed
@camilamacedo86 camilamacedo86 changed the title 🌱 Correct title and description syntax 🌱 grafana/v1-alpha: correct title and description syntax Jul 29, 2022
camilamacedo86
camilamacedo86 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2022
@Kavinjsir
Copy link
Contributor Author

Kavinjsir commented Jul 29, 2022

/retest pull-kubebuilder-e2e-k8s-1-20-7

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 29, 2022

@Kavinjsir: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-kubebuilder-test

The following commands are available to trigger optional jobs:

  • /test pull-kubebuilder-e2e-k8s-1-18-20
  • /test pull-kubebuilder-e2e-k8s-1-19-16
  • /test pull-kubebuilder-e2e-k8s-1-20-7
  • /test pull-kubebuilder-e2e-k8s-1-21-2
  • /test pull-kubebuilder-e2e-k8s-1-22-1
  • /test pull-kubebuilder-e2e-k8s-1-23-3
  • /test pull-kubebuilder-e2e-k8s-1-24-1

Use /test all to run all jobs.

In response to this:

/retest pull-kubebuilder-e2e-k8s-1-20-7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86
Copy link
Member

camilamacedo86 commented Jul 31, 2022

/test pull-kubebuilder-e2e-k8s-1-20-7

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member

camilamacedo86 commented Aug 3, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5c949c2 into kubernetes-sigs:master Aug 3, 2022
@Kavinjsir Kavinjsir mentioned this pull request Sep 14, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

grafana/v1-alpha: Address small nits recommendations on the titles

4 participants

@Kavinjsir @k8s-ci-robot @camilamacedo86 @varshaprasad96