🐛 Clarify deprecate documentation for API methods which are served to work with CRD/WebHook API versions v1beta1 (#3261) #3266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… work with CRD/WebHook API versions v1beta1 (#3261)
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
This PR removes the stale import: "pkg/envtest/printer" that is not needed after migrating to ginko/v2. Controller-runtime v0.14.0+ has migrated to use ginko/v2 and thereby removed "printer" package. The imports were still being scaffolded though not used in the codebase. Signed-off-by: Varsha Prasad Narsing <[email protected]> (cherry picked from commit 8284311)
k8s-ci-robot
added
size/S
varshaprasad96
requested changes
Mar 8, 2023
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/envtest" | ||
| "sigs.k8s.io/controller-runtime/pkg/envtest/printer" |
Member
There was a problem hiding this comment.
This is already merged in master and cherry-picked in 3.9.0
pkg/plugin/util/helpers.go
Outdated
Comment on lines
37
to
38
| // Deprecated: v1beta1 CRDs and Webhooks are not supported since k8s 1.22. | ||
| // The features that allow users to scaffold projects using these API versions are deprecated and are no longer supported. |
Member
There was a problem hiding this comment.
Suggested change
| // Deprecated: v1beta1 CRDs and Webhooks are not supported since k8s 1.22. | |
| // The features that allow users to scaffold projects using these API versions are deprecated and are no longer supported. | |
| // Deprecated: v1beta1 CRDs and Webhooks are not supported since k8s 1.22. | |
| // The features that allow users to scaffold projects using these API versions are deprecated | |
| // and are no longer supported. |
Member
There was a problem hiding this comment.
Just to make linter happy, had to do separate commit in 3.9.0: #3271
🌱 [fix] Linter errors for deprecation message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply change to the master branch
The goal of this PR is just improve the golang documentation about the methods that are marked as deprecated.