Skip to content

🌱 Adding checks to e2e tests to verify make manifest and generate command #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2023
Merged

🌱 Adding checks to e2e tests to verify make manifest and generate command #3468

merged 1 commit into from
Jun 20, 2023

Conversation

@camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jun 20, 2023

Description

Adding checks to e2e tests to verify make manifest and generate command

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 20, 2023
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Jun 20, 2023

Moving forward since it is juts a need to add a couple of checks in the e2e tests.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@camilamacedo86 camilamacedo86 mentioned this pull request Jun 20, 2023
Merged
@camilamacedo86 camilamacedo86 added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3a3d1d9 into kubernetes-sigs:master Jun 20, 2023
@camilamacedo86 camilamacedo86 mentioned this pull request Jun 20, 2023
Closed
@mjlshen mjlshen mentioned this pull request Jun 21, 2023
Closed
@camilamacedo86 camilamacedo86 deleted the test-e2e-add branch June 30, 2023 16:28
@camilamacedo86 camilamacedo86 restored the test-e2e-add branch June 30, 2023 16:28
@camilamacedo86 camilamacedo86 deleted the test-e2e-add branch June 30, 2023 16:28
@camilamacedo86 camilamacedo86 restored the test-e2e-add branch June 30, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camilamacedo86 @k8s-ci-robot