Skip to content

cloudbuild configs to use k8s 1.11 #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2018
Merged

cloudbuild configs to use k8s 1.11 #367

merged 2 commits into from
Sep 4, 2018

Conversation

@droot
Copy link
Contributor

@droot droot commented Aug 29, 2018

No description provided.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2018
@droot droot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2018
@droot droot force-pushed the build-script-use-k8s-1.11 branch from 0de3c9b to dbcafd5 Compare August 31, 2018 20:25
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 31, 2018
@droot droot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2018
@mengqiy
Copy link
Member

mengqiy commented Sep 4, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3afad1c into kubernetes-sigs:master Sep 4, 2018
DirectXMan12
DirectXMan12 reviewed Sep 4, 2018
View reviewed changes
test/projects/memcached-api-server/memcached_test.go
}

func TestDocs(t *testing.T) {
// (droot): Disabling docs test for now because they are broken for k8s 1.1.
Copy link
Contributor

@DirectXMan12 DirectXMan12 Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.11? Or time travel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

1 more reviewer

@DirectXMan12 DirectXMan12 DirectXMan12 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mengqiy mengqiy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@droot @k8s-ci-robot @mengqiy @DirectXMan12