RockyLinux 10 support (experimental)

[tico88612]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add Rocky Linux 10 support

Which issue(s) this PR fixes:

Fixes #12253

Special notes for your reviewer:

Add image first.

Does this PR introduce a user-facing change?:

RockyLinux 10 support (experimental)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tico88612

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tico88612]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yankay]

The CI image has been added:

• [CI] Add CI Image for Rocky Linux 10 #12379
• https://quay.io/repository/kubespray/vm-rockylinux-10?tab=tags

[VannTen]

/retest-failed

[tico88612]

/retest

[tico88612]

/label tide/merge-method-merge

@VannTen, could you take a look at the package installation? kernel-modules-extra needs to align with the OS kernel version, I'm not sure system_package can use a dynamic package name.

[VannTen]

@VannTen, could you take a look at the package installation? kernel-modules-extra needs to align with the OS kernel version, I'm not sure system_package can use a dynamic package name

Hum, isn't there a meta-package or something like that which would let us not use the version in the name ? This looks like we would keep extraneous package whenever the kernel version would change, and since ansible_kernel is probably the running kernel and not the installed one (like, just after an upgrade but before a reboot) I'm not even sure we would install the correct one...

(If there is not... RHEL is kinda insane ? 🤔 or maybe that's me)

[VannTen]

https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/10/html-single/managing_monitoring_and_updating_the_kernel/index

The docs does not seem to expect administrators to specify a version, AFAICT.

[yankay]

How about merging it to move things forward, and creating an issue for better addressing potential problems?
It's LGTM

[VannTen]

I would not enter in the teritory of rebooting and deep node administration.

1. we precheck -> fail, and explain how they could solve it

2. For ci it's different scenario, we can assume they did what was asked (so CI does it too automatically) and then test it.

In short, I suggest we automate the steps in the CI, but to not include it as part of core-kubespray.

Yeah, lets go that route, document then and assume the latest version.

It's a bit tricky to pre-check, I don't think we have a way to know ahead of time if the kernel-modules-extra will match the kernel ? I'd do it with a failed_when on the system_pkgs stuff which search for the version kernel-modules-extra and match it with ansible_kernel, but maybe that's too much ?

[tico88612]

Or what if we add kernel-modules-extra to our Rocky 10 image?

[VannTen]

Yeah, adding it to the image works.

Maybe we can just go without a check, make the support experimental, and handle the installation without kernel-modules-extra in a follow-up ? (maybe with package_facts ? 🤔 )

[tico88612]

Ok, I'll make sure to note here.

Create package-installs.yaml

kernel-modules-extra:
cloud-utils-growpart:
firewalld: # if can't uninstall firewalld, please use customize element and `dnf remove firewalld`
  uninstall: True

Rocky Linux 10 with dib (diskimage-builder)
DIB_RELEASE=10 DIB_IMAGE_EXTRA_SIZE=10240 DIB_CLOUD_INIT_GROWPART_DEVICES=/dev/vda1 disk-image-create -o rockylinux-10-extra -t qcow2 rocky-container vm cloud-init cloud-init-growpart package-installs

[tico88612]

/retest-failed

[tico88612]

/retest-failed

[tico88612]

Finally fixed the Rocky Linux 10 image, and CI is passed. I would really appreciate it if someone could take a look at this.

[yankay]

Thanks @tico88612
Happy new year
LGTM

[VannTen]

/lgtm

Thanks for the persistence !