Skip to content

Conversation

@harche
Copy link
Contributor

@harche harche commented Oct 9, 2025

/kind bug

What type of PR is this?

/kind regression

What this PR does / why we need it:

When testing latest DRA example driver the kueue would fail because upstream has GAed DRA structured params in 1.34 which moved the API from v1beta2 to v1. This PR aligns the DRA API version with the upstream k8s.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

If you bring up the kind cluster using the example DRA driver using make setup-e2e kueue will won't be able to fetch any ResourceClaimTemplates because of the mismatch in DRA API version.

Does this PR introduce a user-facing change?

Update DRA API used from `v1beta2` to `v1`

ACTION REQUIRED: in order to use DRA integration by enabling the DynamicResourceAllocation feature gate in Kueue you need to use k8s 1.34+.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 9, 2025
@netlify
Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 6cb5d7a
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68e704f33ae4e500088cae06
😎 Deploy Preview https://deploy-preview-7212--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

Welcome @harche!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @harche. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2025
@kannon92
Copy link
Contributor

kannon92 commented Oct 9, 2025

/ok-to-test

So this would make this feature only valid for 1.34 K8s.

I’m honestly not sure if this is a an issue for DRA as the feature is alpha.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2025
@harche
Copy link
Contributor Author

harche commented Oct 9, 2025

/ok-to-test

So this would make this feature only valid for 1.34 K8s.

I’m honestly not sure if this is a an issue for DRA as the feature is alpha.

I wasn't able to test the latest commit with the GAed version of DRA without this fix. But please feel free to close this PR if it is not really that big deal.

@mimowo
Copy link
Contributor

mimowo commented Oct 9, 2025

Thank you for the PR.
/lgtm 
/approve

This has been discussed on the initial PR introducing the integration. I flagged that we don't have use cases for 1.33 and early adopters already have a path of using 1.34. See thread.
Now folks who want to experiment on 1.33 and know precisely what they are doing can use Kueue 0.14.

For Kueue 0.15 I want to avoid dragging the cost of maintaining old DRA, and thus blocking integration with the latest features. Even documentation and examples written for v1 will already create friction for users.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 9, 2025

cc @mwysokin @alaypatel07
/hold
I know we talked about this when working on 0.14 with green light to upgrade, but let me know if something changed since then.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 9, 2025

/release-note-edit

Update DRA API used from `v1beta2` to `v1`

ACTION REQUIRED: in order to use DRA integration by enabling the DynamicResourceAllocation feature gate in Kueue you need to use k8s 1.34+.

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 9, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 9, 2025

/remove-kind regression

@k8s-ci-robot k8s-ci-robot removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Oct 9, 2025
@kannon92
Copy link
Contributor

kannon92 commented Oct 9, 2025

@mimowo @tenzen-y

From the wg-batch meeting, I think we are good to unhold this and merge the PR?

@mimowo
Copy link
Contributor

mimowo commented Oct 10, 2025

/unhold
Let's move that forward, thanks 👍 As discussed, we are not cherrypicking this PR on 0.14 branch.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 10, 2025

/remove-kind bug
/kind feature
following the discussion

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Oct 10, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 10, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 40690519aee63684af3a29f5df36fdb641f3c0a3

@k8s-ci-robot k8s-ci-robot merged commit 9ac669d into kubernetes-sigs:main Oct 10, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.15 milestone Oct 10, 2025
@tenzen-y
Copy link
Member

@mimowo @tenzen-y

From the wg-batch meeting, I think we are good to unhold this and merge the PR?

Yes, I agree with them based on yesterday's meeting.

@harche harche deleted the dra_bump branch October 10, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants