-
Notifications
You must be signed in to change notification settings - Fork 480
bump DRA version from v1beta2 to v1 #7212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harshal Patil <[email protected]>
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome @harche! |
|
Hi @harche. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test So this would make this feature only valid for 1.34 K8s. I’m honestly not sure if this is a an issue for DRA as the feature is alpha. |
I wasn't able to test the latest commit with the GAed version of DRA without this fix. But please feel free to close this PR if it is not really that big deal. |
|
Thank you for the PR. This has been discussed on the initial PR introducing the integration. I flagged that we don't have use cases for 1.33 and early adopters already have a path of using 1.34. See thread. For Kueue 0.15 I want to avoid dragging the cost of maintaining old DRA, and thus blocking integration with the latest features. Even documentation and examples written for v1 will already create friction for users. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harche, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @mwysokin @alaypatel07 |
|
/release-note-edit |
|
/remove-kind regression |
|
/unhold |
|
/remove-kind bug |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 40690519aee63684af3a29f5df36fdb641f3c0a3
|
/kind bug
What type of PR is this?
/kind regression
What this PR does / why we need it:
When testing latest DRA example driver the
kueuewould fail because upstream has GAed DRA structured params in 1.34 which moved the API fromv1beta2tov1. This PR aligns the DRA API version with the upstream k8s.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
If you bring up the kind cluster using the example DRA driver using
make setup-e2ekueue will won't be able to fetch anyResourceClaimTemplatesbecause of the mismatch in DRA API version.Does this PR introduce a user-facing change?