-
Notifications
You must be signed in to change notification settings - Fork 649
[cinder-csi-plugin][charts] Remove snapshot controller yamls #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Can you look at the EasyCLA and see if it could be fixed? |
@lingxiankong EasyCLA is optional for kubernetes , kubernetes/test-infra#24381 . |
|
/lgtm |
|
@jichenjc PTAL |
|
/approve @ramineni do we need EasyCLA sign or it's false alert? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
cinder-csi-plugin charts repo hosts snapshot-controller yamls , not CRDs which are required to be deployed along with them which might confuse the users more. As snapshot-controller should be deployed independent of csi driver and its cluster level, we dont need to host/maintain the charts in this repo.
This PR is to remove the same from the repo. The documentation required to deploy the snapshot-controller is already in place pointing to the correct repo.https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/cinder-csi-plugin/features.md#volume-snapshots
Which issue this PR fixes(if applicable):
fixes #1698
Special notes for reviewers:
Release note: