Skip to content

Conversation

@ramineni
Copy link
Contributor

What this PR does / why we need it:
cinder-csi-plugin charts repo hosts snapshot-controller yamls , not CRDs which are required to be deployed along with them which might confuse the users more. As snapshot-controller should be deployed independent of csi driver and its cluster level, we dont need to host/maintain the charts in this repo.

This PR is to remove the same from the repo. The documentation required to deploy the snapshot-controller is already in place pointing to the correct repo.https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/cinder-csi-plugin/features.md#volume-snapshots

Which issue this PR fixes(if applicable):
fixes #1698

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 24, 2021
@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 24, 2021
@ramineni
Copy link
Contributor Author

/cc @jichenjc @lingxiankong

@lingxiankong
Copy link
Contributor

Can you look at the EasyCLA and see if it could be fixed?

@ramineni
Copy link
Contributor Author

Can you look at the EasyCLA and see if it could be fixed?

@lingxiankong EasyCLA is optional for kubernetes , kubernetes/test-infra#24381 .

@lingxiankong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2021
@ramineni
Copy link
Contributor Author

@jichenjc PTAL

@jichenjc
Copy link
Contributor

/approve

@ramineni do we need EasyCLA sign or it's false alert?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9a9976f into kubernetes:master Nov 30, 2021
@ramineni
Copy link
Contributor Author

/approve

@ramineni do we need EasyCLA sign or it's false alert?

@jichenjc we dont need it , its ignored for kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin]Remove snapshot-controller related yaml from charts

4 participants