Skip to content

KEP-1287: Catch up KEP details to actual implementation #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

KEP-1287: Catch up KEP details to actual implementation #3944

merged 1 commit into from
Jun 13, 2023

Conversation

vinaykul
Copy link
Member

@vinaykul vinaykul commented Apr 8, 2023

  • One-line PR description: Catch up the KEP description and details to what actually got implemented after various reviews and discussions.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Apr 8, 2023
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 8, 2023
@vinaykul
Copy link
Member Author

vinaykul commented Apr 8, 2023

/assign @dchen1107
/assign @derekwaynecarr
/cc @thockin

@k8s-ci-robot k8s-ci-robot requested a review from thockin April 8, 2023 16:29
@bart0sh
Copy link
Contributor

bart0sh commented Apr 9, 2023

/assign @mrunalp @SergeyKanzhelev

@Atharva-Shinde Atharva-Shinde mentioned this pull request Jun 9, 2023
Open
95 tasks
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2023
thockin
thockin reviewed Jun 12, 2023
View reviewed changes
thockin
thockin reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text changes LGTM, thanks

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 12, 2023
@mrunalp
Copy link
Contributor

mrunalp commented Jun 13, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, vinaykul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@mrunalp
Copy link
Contributor

mrunalp commented Jun 13, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 87e3a35 into kubernetes:master Jun 13, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thockin thockin thockin left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@mrunalp mrunalp

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

v1.28

Development

Successfully merging this pull request may close these issues.

8 participants

@vinaykul @bart0sh @mrunalp @k8s-ci-robot @thockin @derekwaynecarr @dchen1107 @SergeyKanzhelev