Skip to content

KEP-2305: Metric cardinality enforcement #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2023
Merged

KEP-2305: Metric cardinality enforcement #4039

merged 1 commit into from
Jun 15, 2023

Conversation

@rexagod
Copy link
Member

@rexagod rexagod commented May 27, 2023

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 27, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 27, 2023
@k8s-ci-robot k8s-ci-robot requested a review from dgrisonnet May 27, 2023 18:20
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label May 27, 2023
@k8s-ci-robot k8s-ci-robot requested a review from logicalhan May 27, 2023 18:20
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2023
@rexagod rexagod force-pushed the kep-2035 branch 3 times, most recently from 6fbea83 to 9c823a3 Compare May 28, 2023 18:47
@rexagod rexagod marked this pull request as ready for review May 28, 2023 18:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2023
@rexagod rexagod force-pushed the kep-2035 branch 5 times, most recently from 648c57f to c4bb870 Compare May 28, 2023 22:29
wojtek-t
wojtek-t reviewed May 29, 2023
View reviewed changes
@wojtek-t wojtek-t self-assigned this May 29, 2023
@rexagod
Copy link
Member Author

rexagod commented May 29, 2023

FYI Pod can not be created: create pod test-pod ... 8b2d74b7fa in cluster default: Unauthorized BaseSHA:7cb992000e042d7f20b3e5b72241bd3683c67219.

wojtek-t
wojtek-t reviewed May 30, 2023
View reviewed changes
@wojtek-t wojtek-t removed their assignment May 30, 2023
@logicalhan logicalhan added the lead-opted-in Denotes that an issue has been opted in to a release label May 31, 2023
@logicalhan
Copy link
Member

logicalhan commented May 31, 2023

/stage beta

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label May 31, 2023
@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Jun 1, 2023 •
edited
Loading

Hey @logicalhan can you add the lead-opted-in label on the KEP issue instead of this PR?

@rexagod
Copy link
Member Author

rexagod commented Jun 1, 2023

Ah, right, sorry. I mistakenly asked @logicalhan to add that here instead of the parent issue. 😓

@Atharva-Shinde Atharva-Shinde removed the lead-opted-in Denotes that an issue has been opted in to a release label Jun 2, 2023
enj
enj requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial PRR review as shadow.

@Atharva-Shinde Atharva-Shinde mentioned this pull request Jun 13, 2023
Closed
15 tasks
@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Jun 13, 2023

@rexagod as this KEP is targeting beta you'll need to add response to this question in the Scalability questionnaire of this KEP's Readme.md file.

@rexagod rexagod requested a review from enj June 13, 2023 14:26
@rexagod rexagod force-pushed the kep-2035 branch 3 times, most recently from b8dd972 to 512efa9 Compare June 13, 2023 14:38
enj
enj reviewed Jun 14, 2023
View reviewed changes
@rexagod rexagod force-pushed the kep-2035 branch 2 times, most recently from ef8ffee to df09716 Compare June 14, 2023 18:08
johnbelamaric
johnbelamaric reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good, one minor point but I consider it non-blocking.

I will give the PRR approval once there is SIG approval.

keps/sig-instrumentation/2305-metrics-cardinality-enforcement/README.md
- [x] Feature gate (also fill in values in `kep.yaml`)
- Feature gate name: MetricCardinalityEnforcement
- Components depending on the feature gate: All components that emit metrics
- Components depending on the feature gate: All components that emit metrics, i.e. (at the time of writing),
Copy link
Member

@johnbelamaric johnbelamaric Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spirit of the question is: what binaries do I have to pass this feature gate to? So binary names are what we expect here.

@rexagod
Update KEP-2305: Metric cardinality enforcement
d5fa1a0 
Update KEP-2305: Metric cardinality enforcement based on the reviews
received on kubernetes#2305 to continue the effort further.

Signed-off-by: Pranshu Srivastava <[email protected]>
@logicalhan
Copy link
Member

logicalhan commented Jun 15, 2023 •
edited
Loading

In general this looks good, one minor point but I consider it non-blocking.

I will give the PRR approval once there is SIG approval.

/lgtm (from sig instrumentation)

logicalhan
logicalhan approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2023
@johnbelamaric
Copy link
Member

johnbelamaric commented Jun 15, 2023

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, logicalhan, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 467b387 into kubernetes:master Jun 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enj enj enj requested changes

@johnbelamaric johnbelamaric johnbelamaric left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@logicalhan logicalhan logicalhan approved these changes

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

Assignees

@logicalhan logicalhan

@johnbelamaric johnbelamaric

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Projects

None yet

Milestone

v1.28

Development

Successfully merging this pull request may close these issues.

7 participants

@rexagod @k8s-ci-robot @logicalhan @Atharva-Shinde @johnbelamaric @enj @wojtek-t