Skip to content

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Jan 23, 2024

  • One-line PR description: Keep KEP up-to-date. There're few issues need to be resolved in v1.30
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 23, 2024
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2024
@Jeffwan
Copy link
Member Author

Jeffwan commented Jan 23, 2024

/cc @vinaykul @kubernetes/sig-node-leads

There're few issues not resolved in v1.29 yet. We will try to address them before v1.30 release

@k8s-ci-robot
Copy link
Contributor

@Jeffwan: GitHub didn't allow me to request PR reviews from the following users: kubernetes/sig-node-leads.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @vinaykul @kubernetes/sig-node-leads

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from vinaykul January 23, 2024 14:21
@Jeffwan Jeffwan mentioned this pull request Jan 23, 2024
95 tasks
@bart0sh
Copy link
Contributor

bart0sh commented Jan 25, 2024

/lgtm

/assign @mrunalp @SergeyKanzhelev
for a final approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2024
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit b8d645c into kubernetes:master Feb 3, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 3, 2024
@Jeffwan Jeffwan deleted the jiaxin/kep-1287-v1.30 branch February 4, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

6 participants