Skip to content

KEP-3085: promote to GA in 1.35 #5552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

KEP-3085: promote to GA in 1.35 #5552

wants to merge 4 commits into from
+19 −3

Conversation

Priyankasaggu11929
Copy link
Member

  • One-line PR description: Promote KEP 3085 to GA in 1.35.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 20, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2025
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Aug 26, 2025
Open
24 tasks
@Priyankasaggu11929
Copy link
Member Author

cc: @kannon92 for review. Thanks!

@Priyankasaggu11929
Copy link
Member Author

/assign @kannon92

Priyankasaggu11929
Priyankasaggu11929 commented Sep 23, 2025
View reviewed changes
keps/sig-node/3085-pod-conditions-for-starting-completition-of-sandbox-creation/README.md
- [] Volume Mounting Issues
- [x] Add test to verify sandbox condition for missing configmap.
(added as part of [k/k PR#121321](https://github.com/kubernetes/kubernetes/pull/121321))
- [ ] Add test to verify sandbox condition for missing secret.
Copy link
Member Author

@Priyankasaggu11929 Priyankasaggu11929 Sep 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 - [ ] Add test to verify sandbox condition for missing secret.

This pending test is addressed by kubernetes/kubernetes#134179

kannon92
kannon92 reviewed Sep 30, 2025
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @SergeyKanzhelev @mrunalp @dchen1107

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2025
SergeyKanzhelev
SergeyKanzhelev reviewed Oct 1, 2025
View reviewed changes
keps/sig-node/3085-pod-conditions-for-starting-completition-of-sandbox-creation/kep.yaml
see-also:
- none
replaces:
- none
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update reviewers and approvers for this KEP (or add more)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 2f2f993

Added all three SIG leads mentioned in #5552 (review) along with existing approver/reviewer.

SergeyKanzhelev
SergeyKanzhelev reviewed Oct 1, 2025
View reviewed changes
keps/sig-node/3085-pod-conditions-for-starting-completition-of-sandbox-creation/README.md

- Alpha in 1.25.
- PodHasNetwork renamed to PodReadyToStartContainers in 1.28.
- Beta promotion to 1.29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any use we know of for this condition? GA criteria is not asking for the adoption, but it is a good validation that actually useful condition and there is no "open discussions" that are required by the criteria

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s more informational.

#4138 (comment)

@gjkim42 pointed out that it is being used by external controllers. I have not received any feedback on this feature (positive or negative).

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Priyankasaggu11929
Once this PR has been reviewed and has the lgtm label, please ask for approval from dchen1107 and additionally assign soltysh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mrunalp mrunalp

@kannon92 kannon92

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Priyankasaggu11929 @k8s-ci-robot @kannon92 @SergeyKanzhelev @mrunalp @dchen1107