examples/deepcopy-gen: Document doc.go requirement for =package #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I spent too long scratching my head wondering why I was getting: $ deepcopy-gen -i . --logtostderr --v 5 ... I0918 13:34:13.110855 17959 deepcopy.go:146] Considering pkg "github.com/openshift/installer/pkg/ipnet" I0918 13:34:13.110870 17959 deepcopy.go:164] no tag I0918 13:34:13.110878 17959 deepcopy.go:173] considering type "github.com/openshift/installer/pkg/ipnet.IPNet" I0918 13:34:13.110892 17959 main.go:87] Completed successfully. despite: $ head -n4 ipnet.go // +k8s:deepcopy-gen=package // Package ipnet wraps net.IPNet to get CIDR serialization. package ipnet It looks like only doc.go has been checked for file-level comments since the initial commit in this repository df39b41 (First iteration of go2idl, 2015-10-15). Personally, I'd prefer if this tag could live in any file, but I haven't done the legwork to know if lifting the doc.go restriction would have accidental side-effects or not.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent too long scratching my head wondering why I was getting:
despite:
It looks like only
doc.gohas been checked for file-level comments since the initial commit in this repository df39b41 (2015-10-15).Personally, I'd prefer if this tag could live in any file, but I haven't done the legwork to know if lifting the
doc.gorestriction would have accidental side-effects or not.