Skip to content

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Sep 24, 2025

following up from the creation of the karpenter cluster-api group, this change adds the registry files for the controller.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2025
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/infra Infrastructure management, infrastructure design, code in infra/ size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/registry.k8s.io Code in registry.k8s.io/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Sep 24, 2025
@elmiko
Copy link
Contributor Author

elmiko commented Sep 24, 2025

@ameukam i followed the example from #8448, but i wasn't sure about the promoter manifest. happy to fix this up as necessary.

@elmiko
Copy link
Contributor Author

elmiko commented Sep 24, 2025

for reference, previous PR #8495

@ameukam
Copy link
Member

ameukam commented Sep 24, 2025

You can put something like:

# No images yet

in registry.k8s.io/images/k8s-staging-karpenter-cluster-api/images.yaml so the image promoter will not attempt to promote an empty file.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elmiko, justinsb
Once this PR has been reviewed and has the lgtm label, please assign priyankasaggu11929 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2025
@elmiko
Copy link
Contributor Author

elmiko commented Sep 25, 2025

updated with @ameukam 's suggestion.

once the registry is created, is there some documentation or an example of how we add images?

@ameukam
Copy link
Member

ameukam commented Sep 29, 2025

The manifest's path is missing in ./registry.k8s.io/manifests.

@ameukam
Copy link
Member

ameukam commented Sep 29, 2025

atlantis plan

@k8s-infra-ci-robot
Copy link
Contributor

Ran Plan for dir: infra/gcp/terraform/k8s-staging-images workspace: default

Plan Failed: This project is currently locked by an unapplied plan from pull #8565. To continue, delete the lock from #8565 or apply that plan and merge the pull request.

Once the lock is released, comment atlantis plan here to re-plan.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2025
@elmiko
Copy link
Contributor Author

elmiko commented Sep 29, 2025

@ameukam , i added the manifest directory and copied the promoter file from cluster-api with modifications for the karpenter names. i hope i did that correctly XD

@k8s-ci-robot
Copy link
Contributor

@elmiko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-k8sio-cip e77813c link true /test pull-k8sio-cip

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

- name: us-west1-docker.pkg.dev/k8s-artifacts-prod/images/karpenter-cluster-api
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-west2-docker.pkg.dev/k8s-artifacts-prod/images/karpenter-cluster-api
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
imagesPath: "../../images/k8s-staging-karpenter-cluster-api/images.yaml"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/registry.k8s.io Code in registry.k8s.io/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants