-
Notifications
You must be signed in to change notification settings - Fork 925
add karpenter cluster api staging registry #8557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for reference, previous PR #8495 |
You can put something like: # No images yet in |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elmiko, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e85de3e
to
d3ca75a
Compare
New changes are detected. LGTM label has been removed. |
updated with @ameukam 's suggestion. once the registry is created, is there some documentation or an example of how we add images? |
The manifest's path is missing in |
atlantis plan |
Ran Plan for dir: Plan Failed: This project is currently locked by an unapplied plan from pull #8565. To continue, delete the lock from #8565 or apply that plan and merge the pull request. Once the lock is released, comment |
d3ca75a
to
e77813c
Compare
@ameukam , i added the manifest directory and copied the promoter file from cluster-api with modifications for the karpenter names. i hope i did that correctly XD |
@elmiko: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- name: us-west1-docker.pkg.dev/k8s-artifacts-prod/images/karpenter-cluster-api | ||
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com | ||
- name: us-west2-docker.pkg.dev/k8s-artifacts-prod/images/karpenter-cluster-api | ||
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com | |
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com | |
imagesPath: "../../images/k8s-staging-karpenter-cluster-api/images.yaml" |
following up from the creation of the karpenter cluster-api group, this change adds the registry files for the controller.