Add hakman as an approver #1121
Conversation
k8s-ci-robot
added
cncf-cla: yes
hakman
force-pushed
the
hakman-approver
branch
from
6d32741 to
ec827a1
Compare
|
@vteratipally doesn't seem to be a member of the org anymore, see kubernetes/org#5665. |
| - andyxning | ||
| - wangzhen127 | ||
| - xueweiz | ||
| - vteratipally |
There was a problem hiding this comment.
let's introduce emeritus here?
Co-authored-by: Sergey Kanzhelev <[email protected]>
k8s-ci-robot
added
the
do-not-merge/invalid-owners-file
There was a problem hiding this comment.
@hakman: 1 invalid OWNERS file
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
| @@ -1,14 +1,16 @@ | |||
| reviewers: | |||
| - sig-node-reviewers | |||
| - andyxning | |||
There was a problem hiding this comment.
Cannot parse file: error converting YAML to JSON: yaml: line 13: did not find expected '-' indicator.
There was a problem hiding this comment.
@hakman: 1 invalid OWNERS file
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
| @@ -1,14 +1,15 @@ | |||
| reviewers: | |||
| - sig-node-reviewers | |||
| - andyxning | |||
There was a problem hiding this comment.
Cannot parse file: error converting YAML to JSON: yaml: line 13: did not find expected '-' indicator.
k8s-ci-robot
removed
the
do-not-merge/invalid-owners-file
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
lgtm
|
/lgtm Thanks for all your effort! @hakman |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, SergeyKanzhelev, wangzhen127 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hakman
added
the
tide/merge-method-squash
|
Thank you both 🙂 |
k8s-ci-robot
removed
the
do-not-merge/hold
* Add hakman as an approver * Remove vteratipally * Add emeritus Co-authored-by: Sergey Kanzhelev <[email protected]> * Update OWNERS * Update OWNERS --------- Co-authored-by: Sergey Kanzhelev <[email protected]>
4 participants
/cc @wangzhen127 @SergeyKanzhelev